Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backupccl: SHOW BACKUP FILES/SCHEMAS/RANGES is incompatible with SHOW BACKUP IN #77697

Closed
msbutler opened this issue Mar 11, 2022 · 1 comment · Fixed by #77871
Closed

backupccl: SHOW BACKUP FILES/SCHEMAS/RANGES is incompatible with SHOW BACKUP IN #77697

msbutler opened this issue Mar 11, 2022 · 1 comment · Fixed by #77871
Assignees
@msbutler
Labels
A-disaster-recovery C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-disaster-recovery

Comments

@msbutler
Copy link
Collaborator

msbutler commented Mar 11, 2022 •
edited by cockroach-jira-scripts
Loading

Currently, the parser cannot run SHOW BACKUP FILES/SCHEMAS/RANGES on a collection via SHOW BACKUP IN. They can only run using the old syntax.

Jira issue: CRDB-13721
@msbutler msbutler added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-disaster-recovery T-disaster-recovery labels Mar 11, 2022
@msbutler msbutler self-assigned this Mar 11, 2022
@blathers-crl
Copy link

blathers-crl bot commented Mar 11, 2022

cc @cockroachdb/bulk-io

msbutler added a commit to msbutler/cockroach that referenced this issue Mar 16, 2022
@msbutler
backupccl: allow SHOW BACKUP FILES/RANGES/SCHEMAS in backup collections
f511c98 
Fixes cockroachdb#77697

Release justification: low risk bug fixes

Release note: None
@msbutler msbutler mentioned this issue Mar 16, 2022
Merged
craig bot pushed a commit that referenced this issue Mar 18, 2022
@abarganier @msbutler @maryliag
Merge #77684 #77871 #78050 #78084
0555306 
77684: pkg/server: add pagination fields to TenantRanges/Ranges request/response protos r=rimadeodhar a=abarganier

The `(*statusServer).Ranges()` endpoint currently supports pagination
under the hood, but this functionality is not accessible via RPC requests.
Instead, pagination is only currently available via api_v2.

There are multiple callers of the `Ranges()` endpoint outside of api_v2
(e.g. `debug zip`) that could benefit from having this pagination
functionality unlocked. Therefore, this change adds `limit` and `offset`
fields to the associated request object, and a `next` field to the
response object. This allows gRPC callers to leverage the offset
pagination already in place.

Now that `Ranges()` supports pagination for gRPC clients, we can extend
that pagination functionality to the `TenantRanges` endpoint as well.

The pagination for `TenantRanges()` will limit the number of results returned
*by each node*. This means that a `limit = 100` value for a tenant whose
ranges are replicated three times, will return 300 results (100 results for
each node containing a Replica).

Release note: none

Release justification: Low risk, high benefit changes to existing functionality

77871: backupccl: allow SHOW BACKUP FILES/RANGES/SCHEMAS in backup collections r=adityamaru,dt a=msbutler

Fixes #77697

Release justification: low risk bug fixes

Release note: SHOW BACKUP SCHEMAS can be called with SHOW BACKUP IN syntax.

78050: ui: fix broken links to statement details r=maryliag a=maryliag

Previously the statement links on Advanced Debug
and Sessions page that would open the Statement Details page
were crashing.
This commits fixes the correcy path on the Advanced Debug
link and removes the link on the Sessions page, since that
one would not make sense for active queries. In the future
we can add link for past queries.
This commits also fixes the position of the Statement
on the Sessions table.

Fixes #77978

Previous alignment
<img width="836" alt="Screen Shot 2022-03-17 at 5 18 11 PM" src="https://user-images.githubusercontent.com/1017486/158897680-9c77db56-f16e-4157-b051-97338bc5674b.png">


Fixed alignment
<img width="993" alt="Screen Shot 2022-03-17 at 5 13 54 PM" src="https://user-images.githubusercontent.com/1017486/158897703-55310df1-5b52-4856-94f7-6d30d81acdae.png">


Release note (bug fix): Fix broken links to Statement Details
page on Advanced Debug and Sessions page.

78084: ui: ui updates to Database page r=maryliag a=maryliag

This commit introduces ui fixes on the Database page (and other
child pages of it)
Partially addresses #77982

- Auto Stats circle is no longer cut off
Before
<img width="265" alt="Screen Shot 2022-03-18 at 10 20 26 AM" src="https://user-images.githubusercontent.com/1017486/159035594-ab378c69-657d-4898-90cb-500aeb7775c5.png">
After
<img width="288" alt="Screen Shot 2022-03-18 at 10 23 14 AM" src="https://user-images.githubusercontent.com/1017486/159035651-bcf4eb96-4568-4c45-9115-48476233bba3.png">


- Added the link style to the link on Auto Stats tooltip
<img width="299" alt="Screen Shot 2022-03-18 at 10 45 17 AM" src="https://user-images.githubusercontent.com/1017486/159035698-3aa337c3-e6cb-42bf-aa60-a9d6ba78d9bf.png">


- Updated tooltip message on reset index stats to add
`from the time the index was created or had its stats reset`
Before
<img width="381" alt="Screen Shot 2022-03-18 at 11 13 38 AM" src="https://user-images.githubusercontent.com/1017486/159035750-1af30635-aebb-47f9-b40a-d4bf9debe67a.png">
After
<img width="313" alt="Screen Shot 2022-03-18 at 11 15 03 AM" src="https://user-images.githubusercontent.com/1017486/159035788-b30153dd-1a1b-4aca-b8c0-62fb42614281.png">


- Updated the reset stats link when hover to use the correct blue
and add underline
<img width="242" alt="Screen Shot 2022-03-18 at 11 35 02 AM" src="https://user-images.githubusercontent.com/1017486/159035996-3d2a0b7c-4ac9-4ec0-a004-424dff4595a4.png">


- Adjusted alignment of summary cards inside Table details
Before
<img width="357" alt="Screen Shot 2022-03-18 at 11 26 17 AM" src="https://user-images.githubusercontent.com/1017486/159035880-21f75ad2-3c6d-4ece-ad7d-c12500ef25c9.png">
After
<img width="443" alt="Screen Shot 2022-03-18 at 11 31 21 AM" src="https://user-images.githubusercontent.com/1017486/159035944-8c19eaae-4fc6-4855-b597-17589fce115e.png">



Release note: None

Co-authored-by: Alex Barganier <[email protected]>
Co-authored-by: Michael Butler <[email protected]>
Co-authored-by: Marylia Gutierrez <[email protected]>
@craig craig bot closed this as completed in 71b8b0c Mar 18, 2022
msbutler added a commit to msbutler/cockroach that referenced this issue Mar 31, 2022
@msbutler
backupccl: allow SHOW BACKUP FILES/RANGES/SCHEMAS in backup collections
d105986 
Fixes cockroachdb#77697

Release justification: low risk bug fixes

Release note: None
fqazi pushed a commit to fqazi/cockroach that referenced this issue Apr 4, 2022
@msbutler @fqazi
backupccl: allow SHOW BACKUP FILES/RANGES/SCHEMAS in backup collections
bd2e2e5 
Fixes cockroachdb#77697

Release justification: low risk bug fixes

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msbutler msbutler

Labels
A-disaster-recovery C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-disaster-recovery
Projects
No open projects
Disaster Recovery Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

backupccl: allow SHOW BACKUP FILES/RANGES/SCHEMAS in backup collections msbutler/cockroach
1 participant
@msbutler