ui: ui updates to Database page #78084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces ui fixes on the Database page (and other child pages of it): Partially addresses cockroachdb#77982 - Auto Stats circle is no longer cut off - Added the link style to the link on Auto Stats tooltip - Updated tooltip message on reset index stats to add `from the time the index was created or had its stats reset` - Updated the reset stats link when hover to use the correct blue and add underline - Adjusted alignment of summary cards inside Table details Release note: None
|
This change is |
|
@maryliag one question: on the index detail page, does the bullet for summary card alignment also address the issue of the index stats table not resizing with the SQL box/summary cards when the browser window is resized? Or is that a separate issue? |
|
@Annebirzin it doesn't (I just noticed that one and fixed anyway 😄 ) Our table component does not resize like that, so that will be something we will work later on, but I don't think I can get that in for GA. And the new behaviour would affect all tables. |
matthewtodd
approved these changes
Mar 18, 2022
complete! 1 of 0 LGTMs obtained
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces ui fixes on the Database page (and other
child pages of it)
Partially addresses #77982
Before
Afterfrom the time the index was created or had its stats resetBefore
Afterand add underline
Before
AfterRelease note: None