CalorimeterDefinitions: don't return -1 as uint32_t

[iarspider]

PR description:

I have checked all usages of detId2denseId, and there is no explicit comparison with -1 or similar value, so I think it's safe to return 0 instead of (unit32_t) -1.

For reference: gcc13 emits a warning link

src/RecoParticleFlow/PFRecHitProducer/plugins/alpaka/CalorimeterDefinitions.h(104): warning #68-D: integer conversion resulted in a change of sign
        return -1;
               ^

PR validation:

Bot tests

[cmsbuild]

cms-bot internal usage

[iarspider]

please test for el8_amd64_gcc13
build will most likely fail, but the warning should be gone

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44608/39797

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• RecoParticleFlow/PFRecHitProducer (reconstruction)

@mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@mmarionncern, @lgray, @seemasharmafnal, @hatakeyamak, @missirol this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test for el9_amd64_gcc13

[cmsbuild]

-1

Failed Tests: Build HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c22e8/38593/summary.html
COMMIT: f0e4f78
CMSSW: CMSSW_14_1_X_2024-04-01-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44608/38593/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @24LopezR Add reco::Muon displacedMuons to offline validation sequences #44353
• @vlimant l1nano import location #44391
• @esiam JME DQM implementation of Z/Gamma plus Jet monitoring for Run3 (14_1_X) #44411
• @iarspider [CPP20][DQM] Replace some enums with constexpr ints #44515
• @stahlleiton Add PF HF sum energy to reco::Centrality #44518
• @dinyar Unpack displaced pT from OMTF at the uGMT inputs #44543
• @rovere Add HGCAL Hit calibration to Phase2 HLT. #44558
• @radla118 Update of the LumiPCC module veto list and afterglow factors for 2024 #44568
• @mmusich add a unit test for conversion of millepede.res files into DB payloads #44570
• @riga Slight update to TensorFlowAOT interface. #44586
• @mmusich TkAl: protect unit tests against empty queries and drop unused tests #44588
• @Dr15Jones Temporary: abort if cutParser fails to find methods #44590
• @stahlleiton Change unsubjet_map in btag info producers to tracked #44591
• @civanch [14_1_X SIM] Clean-up MC truth infrastructure #44593
• @dan131riley move DataRecord includes to HBHERecHitProducerGPU #44595

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c22e8/38593/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c22e8/38593/git-merge-result

Build

I found compilation error when building:

/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02831/el9_amd64_gcc13/external/gcc/13.2.0-1b0a3367d04f48f01ad3ccf40e55475c/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.2.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lSimDataFormatsTrackingAnalysis: No such file or directory
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02831/el9_amd64_gcc13/external/gcc/13.2.0-1b0a3367d04f48f01ad3ccf40e55475c/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.2.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lDataFormatsTrackReco: No such file or directory
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02831/el9_amd64_gcc13/external/gcc/13.2.0-1b0a3367d04f48f01ad3ccf40e55475c/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.2.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lDataFormatsTrackCandidate: No such file or directory
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02831/el9_amd64_gcc13/external/gcc/13.2.0-1b0a3367d04f48f01ad3ccf40e55475c/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.2.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lDataFormatsTrajectorySeed: No such file or directory
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02831/el9_amd64_gcc13/external/gcc/13.2.0-1b0a3367d04f48f01ad3ccf40e55475c/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.2.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lDataFormatsTrackingRecHit: No such file or directory
collect2: error: ld returned 1 exit status
gmake: *** [tmp/el9_amd64_gcc13/src/Validation/RecoHI/plugins/CmsHiValidationPlugins/libCmsHiValidationPlugins.so] Error 1
Leaving library rule at src/Validation/RecoHI/plugins
>> Leaving Package Validation/RecoHI
>> Package Validation/RecoHI built
>> Entering Package CondFormats/External


[iarspider]

failures are expected (unrelated)

[iarspider]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c22e8/38618/summary.html
COMMIT: f0e4f78
CMSSW: CMSSW_14_1_X_2024-04-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44608/38618/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 77 lines from the logs
• Reco comparison results: 50 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3307717
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3307691
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1

[fwyzard]

@fllor FYI

[fwyzard]

type pf

[fllor]

@fllor FYI

Thanks.

This return statement should never executed, so the returned value does not really matter.

[fwyzard]

Unfortunately it turns out that this change was a bad idea.

In fact, 0 is a perfectly valid compact id, so it should not be used for an invalid id.

The HCAL PF code (e.g. in RecoParticleFlow/PFRecHitProducer/plugins/alpaka/PFRecHitTopologyESProducer.cc) uses 0xffffffff to mark invalid det ids.

While that has its own problems (neighbours is of type int32_t, while the values returned by neighbours are of type uint32_t) it is at least consistent.
Changing the return value for invalid det id to 0 breaks the convention.