-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CalorimeterDefinitions: don't return -1 as uint32_t #44608
Conversation
cms-bot internal usage |
please test for el8_amd64_gcc13 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44608/39797
|
A new Pull Request was created by @iarspider for master. It involves the following packages:
@mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test for el9_amd64_gcc13 |
-1 Failed Tests: Build HeaderConsistency The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: BuildI found compilation error when building: /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02831/el9_amd64_gcc13/external/gcc/13.2.0-1b0a3367d04f48f01ad3ccf40e55475c/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.2.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lSimDataFormatsTrackingAnalysis: No such file or directory /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02831/el9_amd64_gcc13/external/gcc/13.2.0-1b0a3367d04f48f01ad3ccf40e55475c/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.2.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lDataFormatsTrackReco: No such file or directory /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02831/el9_amd64_gcc13/external/gcc/13.2.0-1b0a3367d04f48f01ad3ccf40e55475c/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.2.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lDataFormatsTrackCandidate: No such file or directory /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02831/el9_amd64_gcc13/external/gcc/13.2.0-1b0a3367d04f48f01ad3ccf40e55475c/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.2.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lDataFormatsTrajectorySeed: No such file or directory /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02831/el9_amd64_gcc13/external/gcc/13.2.0-1b0a3367d04f48f01ad3ccf40e55475c/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.2.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lDataFormatsTrackingRecHit: No such file or directory collect2: error: ld returned 1 exit status gmake: *** [tmp/el9_amd64_gcc13/src/Validation/RecoHI/plugins/CmsHiValidationPlugins/libCmsHiValidationPlugins.so] Error 1 Leaving library rule at src/Validation/RecoHI/plugins >> Leaving Package Validation/RecoHI >> Package Validation/RecoHI built >> Entering Package CondFormats/External |
failures are expected (unrelated) |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c22e8/38618/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@fllor FYI |
type pf |
Thanks. This return statement should never executed, so the returned value does not really matter. |
Unfortunately it turns out that this change was a bad idea. In fact, The HCAL PF code (e.g. in While that has its own problems ( |
This reverts commit f0e4f78. The change introduced by f0e4f78 / cms-sw#44608 returns a dense id of 0 for an invalid det id. However, 0 is a valid dense id, and should not be used for an invalid det id.
PR description:
I have checked all usages of
detId2denseId
, and there is no explicit comparison with-1
or similar value, so I think it's safe to return0
instead of(unit32_t) -1
.For reference: gcc13 emits a warning link
PR validation:
Bot tests