Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TkAl: protect unit tests against empty queries and drop unused tests #44588

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 2, 2024

PR description:

This PR is in response to #44467 (comment).
Protect the unit test such that it doesn't fail in case the DAS query doesn't find any useful run (which should not happen in any case).
Also in fe9b0a5 drop an unused test configuration.

PR validation:

Run successfully:

  • scram b runtests_SubmitPVsplit
  • scram b runtests_SubmitPVrbr

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, not to be backported.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44588/39757

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@consuegs, @perrotta, @saumyaphor4252, @cmsbuild can you please review it and eventually sign? Thanks.
@adewit, @tocheng, @tlampen, @mmusich, @rsreds, @yuanchao this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Apr 2, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Apr 3, 2024

@cmsbuild, please abort

@mmusich
Copy link
Contributor Author

mmusich commented Apr 3, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-337b91/38570/summary.html
COMMIT: fe9b0a5
CMSSW: CMSSW_14_1_X_2024-04-02-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44588/38570/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 47 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3304819
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3304796
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Apr 3, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants