-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TkAl: protect unit tests against empty queries and drop unused tests #44588
Conversation
….sh when DAS returns no runnable output
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44588/39757
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@consuegs, @perrotta, @saumyaphor4252, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
@cmsbuild, please abort |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-337b91/38570/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is in response to #44467 (comment).
Protect the unit test such that it doesn't fail in case the DAS query doesn't find any useful run (which should not happen in any case).
Also in fe9b0a5 drop an unused test configuration.
PR validation:
Run successfully:
scram b runtests_SubmitPVsplit
scram b runtests_SubmitPVrbr
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, not to be backported.