Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOT]Updated root version to 6.30.06 #9112

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/master.

@smuzaffar, @cmsbuild, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2024

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12b3da/38586/summary.html
COMMIT: 4d2da8a
CMSSW: CMSSW_14_1_X_2024-04-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9112/38586/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12b3da/38586/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12b3da/38586/git-merge-result

Unit Tests

I found 2 errors in the following unit tests:

---> test TestIOPoolInputNoParentDictionary had ERRORS
---> test runtestPhysicsToolsPatAlgos had ERRORS

Comparison Summary

There are some workflows for which there are errors in the baseline:
24834.78 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially removed 105 lines from the logs
  • Reco comparison results: 50 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3304819
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3304790
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 23259.64300000001 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 2539.485 KiB HLT/JME
  • DQMHistoSizes: changed ( 140.56,... ): 10.652 KiB Physics/Centrality
  • DQMHistoSizes: changed ( 23234.0,... ): 3.979 KiB HGCalHitCalibrationHLT/hgcal_photon_EoP_CPene_scint_calib_fraction
  • DQMHistoSizes: changed ( 23234.0,... ): 3.977 KiB HGCalHitCalibrationHLT/hgcal_photon_EoP_CPene_100_calib_fraction
  • DQMHistoSizes: changed ( 23234.0,... ): 3.977 KiB HGCalHitCalibrationHLT/hgcal_photon_EoP_CPene_200_calib_fraction
  • DQMHistoSizes: changed ( 23234.0,... ): 3.977 KiB HGCalHitCalibrationHLT/hgcal_photon_EoP_CPene_300_calib_fraction
  • DQMHistoSizes: changed ( 23234.0,... ): 3.976 KiB HGCalHitCalibrationHLT/hgcal_ele_EoP_CPene_scint_calib_fraction
  • DQMHistoSizes: changed ( 23234.0,... ): 3.974 KiB HGCalHitCalibrationHLT/hgcal_ele_EoP_CPene_100_calib_fraction
  • DQMHistoSizes: changed ( 23234.0,... ): 3.974 KiB HGCalHitCalibrationHLT/hgcal_ele_EoP_CPene_200_calib_fraction
  • DQMHistoSizes: changed ( 23234.0,... ): 3.974 KiB HGCalHitCalibrationHLT/hgcal_ele_EoP_CPene_300_calib_fraction
  • DQMHistoSizes: changed ( 23234.0 ): ...
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

ignore tests-rejected with ib-failure

  • TestIOPoolInputNoParentDictionary always fail when we change the root version. Test mixes the root version of IB and PR which causes root failures
  • runtestPhysicsToolsPatAlgos is know failure in IBs

@smuzaffar
Copy link
Contributor Author

+externals

@makortel , any objections on updating ROOT to latest version 6.30.06 for 14.1.X (changes on top of existing root commit we use are root-project/root@bd1b2a6...9be8ca1 )

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2024

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor Author

lets get this in 14.1.X

@smuzaffar smuzaffar merged commit cb0edba into cms-sw:IB/CMSSW_14_1_X/master Apr 8, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants