Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change unsubjet_map in btag info producers to tracked #44591

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

stahlleiton
Copy link
Contributor

PR description:

This PR change the unsubjet_map variable in the BTag info producers to tracked as requested in #44422 (comment)

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44591/39765

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

A new Pull Request was created by @stahlleiton for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)
  • RecoBTag/FeatureTools (reconstruction)

@jfernan2, @cmsbuild, @Martin-Grunewald, @mmusich, @mandrenguyen can you please review it and eventually sign? Thanks.
@silviodonato, @missirol, @emilbols, @AnnikaStein, @demuller, @SohamBhattacharya, @Senphy, @Ming-Yan, @JyothsnaKomaragiri, @hqucms, @AlexDeMoor, @rovere, @andrzejnovak, @Martin-Grunewald this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2625a/38553/summary.html
COMMIT: 7d4b9a6
CMSSW: CMSSW_14_1_X_2024-04-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44591/38553/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 50 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297469
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3297446
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@antoniovilela
Copy link
Contributor

type bug-fix

@mandrenguyen
Copy link
Contributor

type btv

@mandrenguyen
Copy link
Contributor

+1

@stahlleiton stahlleiton force-pushed the UnsubjetMapTracked_CMSSW_14_1_X branch from a7ab886 to 169cad2 Compare April 3, 2024 08:22
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44591/39778

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

Pull request #44591 was updated. @mmusich, @cmsbuild, @Martin-Grunewald can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Apr 3, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2625a/38566/summary.html
COMMIT: 169cad2
CMSSW: CMSSW_14_1_X_2024-04-02-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44591/38566/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor

mmusich commented Apr 3, 2024

+hlt

  • PR according description and follow-up review

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants