Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_1_X] Bumped CepGen version to 1.2.3 #9122

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

forthommel
Copy link
Contributor

This PR bumps the version of CepGen to 1.2.3.
Changelog is available here.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

A new Pull Request was created by @forthommel for branch IB/CMSSW_14_1_X/master.

@iarspider, @smuzaffar, @cmsbuild, @aandvalenzuela can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

cms-bot internal usage

@forthommel forthommel changed the title Bumped CepGen version to 1.2.3 [14_1_X] Bumped CepGen version to 1.2.3 Apr 6, 2024
@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38651/summary.html
COMMIT: b847a34
CMSSW: CMSSW_14_1_X_2024-04-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9122/38651/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38651/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38651/git-merge-result

Build

I found compilation error when building:

>> Package GeneratorInterface/CepGenInterface built
Entering library rule at src/GeneratorInterface/CepGenInterface/plugins
>> Compiling edm plugin src/GeneratorInterface/CepGenInterface/plugins/CepGenGeneratorFilter.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-04-06-1100/src/GeneratorInterface/CepGenInterface/interface/CepGenGeneratorFilter.h:8,
                 from src/GeneratorInterface/CepGenInterface/plugins/CepGenGeneratorFilter.cc:5:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-04-06-1100/src/GeneratorInterface/CepGenInterface/interface/CepGenEventGenerator.h:36:19: error: 'ParametersList' in namespace 'cepgen' does not name a type
   36 |     const cepgen::ParametersList proc_params_;
      |                   ^~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-04-06-1100/src/GeneratorInterface/CepGenInterface/interface/CepGenEventGenerator.h:37:48: error: 'ParametersList' is not a member of 'cepgen'
   37 |     std::vector > modif_modules_, output_modules_;
      |                                                ^~~~~~~~~~~~~~


@forthommel
Copy link
Contributor Author

cms-sw/cmssw#44647 should fix this issue. Backports to 13_0_X and 10_6_X should be issued too.

@smuzaffar
Copy link
Contributor

test parameters:
pull_request = cms-sw/cmssw#44647

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38656/summary.html
COMMIT: b847a34
CMSSW: CMSSW_14_1_X_2024-04-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9122/38656/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38656/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38656/git-merge-result

Comparison Summary

Summary:

  • You potentially added 104 lines to the logs
  • Reco comparison results: 50 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3307717
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3307694
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

please test for el8_aarch64_gcc12

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38770/summary.html
COMMIT: b847a34
CMSSW: CMSSW_14_1_X_2024-04-09-2300/el8_aarch64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9122/38770/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38770/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38770/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38765/summary.html
COMMIT: b847a34
CMSSW: CMSSW_14_1_X_2024-04-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9122/38765/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38765/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38765/git-merge-result

Unit Tests

I found 2 errors in the following unit tests:

---> test TestGeneratorInterfacePythia8ConcurrentGeneratorFilter had ERRORS
---> test runtestPhysicsToolsPatAlgos had ERRORS

Comparison Summary

There are some workflows for which there are errors in the baseline:
546.0 step 2
547.0 step 3
548.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 116 lines to the logs
  • Reco comparison results: 53 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3316263
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3316240
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@forthommel
Copy link
Contributor Author

Hello @smuzaffar!
I must admit I am now lost in your release/architectures validation plan. Could you please let me know if there is a list of conditions I should test locally in addition to the standard ones?

@smuzaffar
Copy link
Contributor

+externals

unit tests failure are not related to this update ( these tests are failing for cmssw IBs)

@forthommel , I just wanted to make sure new version builds for all supported archs.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#44647

@forthommel
Copy link
Contributor Author

+externals

unit tests failure are not related to this update ( these tests are failing for cmssw IBs)

@forthommel , I just wanted to make sure new version builds for all supported archs.

Many thanks for your detailed explanation, @smuzaffar! I am reassured that this single extra include line is not breaking all the future workflows :-)

@smuzaffar
Copy link
Contributor

please test

lets refresh the tests

@forthommel
Copy link
Contributor Author

@smuzaffar This PhysicsTools/PatAlgos failed unit test looks fairly platform-independent...

@iarspider
Copy link
Contributor

@smuzaffar This PhysicsTools/PatAlgos failed unit test looks fairly platform-independent...

@forthommel this one is known: cms-sw/cmssw#33084 (comment)

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38842/summary.html
COMMIT: b847a34
CMSSW: CMSSW_14_1_X_2024-04-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9122/38842/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38842/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38842/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially added 95 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 99 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3317863
  • DQMHistoTests: Total failures: 26
  • DQMHistoTests: Total nulls: 5
  • DQMHistoTests: Total successes: 3317812
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3146.823999999999 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.247 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 12834.0,... ): 448.699 KiB HLT/EXO
  • DQMHistoSizes: changed ( 12834.0,... ): 0.445 KiB HLT/Filters
  • DQMHistoSizes: changed ( 13234.0,... ): 0.120 KiB Physics/NanoAODDQM
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @rappoccio, @antoniovilela: This PR was tested with cms-sw/cmssw#44647, please check if they should be merged together

@rappoccio
Copy link

+1

Tests in cmssw PR are passing

@rappoccio
Copy link

merge

@cmsbuild cmsbuild merged commit ca30f8a into cms-sw:IB/CMSSW_14_1_X/master Apr 19, 2024
14 of 17 checks passed
@forthommel forthommel deleted the cepgen-14_1_X branch April 19, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants