Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10_6_X] CepGenInterface: Added missing include #44648

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

forthommel
Copy link
Contributor

PR description:

This PR fixes the build of CepGen release >= 1.2.2 where the include chain was strongly modified. This should cure the recent build failure encountered in cms-sw/cmsdist#9123.

PR validation:

Builds

Backport of #44647

FYI: @smuzaffar, @bbilin

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

A new Pull Request was created by @forthommel for CMSSW_10_6_X.

It involves the following packages:

  • GeneratorInterface/CepGenInterface (generators)

@mkirsano, @menglu21, @bbilin, @SiewYan, @alberto-sanchez, @cmsbuild, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@mkirsano, @alberto-sanchez this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

cms-bot internal usage

@forthommel forthommel changed the title Added parameters list include [10_6_X] CepGenInterface: Added missing include Apr 6, 2024
@menglu21
Copy link
Contributor

menglu21 commented Apr 9, 2024

@cmsbuild please test

@menglu21
Copy link
Contributor

menglu21 commented Apr 9, 2024

@cmsbuild abort

@menglu21
Copy link
Contributor

menglu21 commented Apr 9, 2024

@cmsbuild please test with cms-sw/cmsdist#9122

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ef280/38700/summary.html
COMMIT: 0582dea
CMSSW: CMSSW_10_6_X_2024-04-07-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44648/38700/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

@forthommel
Copy link
Contributor Author

@menglu21 I believe this:

ERROR: Duplicate data package definitions found in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cmsdist/data/cmsswdata.txt for package RecoBTag-Combined

is nowhere related to this PR?

@menglu21
Copy link
Contributor

menglu21 commented Apr 9, 2024

@menglu21 I believe this:

ERROR: Duplicate data package definitions found in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cmsdist/data/cmsswdata.txt for package RecoBTag-Combined

is nowhere related to this PR?

I think I need to use #9123 instead of #9122, let's do the test again

@menglu21
Copy link
Contributor

menglu21 commented Apr 9, 2024

@cmsbuild please test with cms-sw/cmsdist#9123

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ef280/38709/summary.html
COMMIT: 0582dea
CMSSW: CMSSW_10_6_X_2024-04-07-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44648/38709/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@menglu21
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#9123

@cmsbuild
Copy link
Contributor

REMINDER @antoniovilela, @sextonkennedy, @rappoccio: This PR was tested with cms-sw/cmsdist#9123, please check if they should be merged together

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6c18860 into cms-sw:CMSSW_10_6_X Apr 22, 2024
10 checks passed
@forthommel forthommel deleted the cepgen_patch-10_6_X branch April 22, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants