-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move DataRecord includes to HBHERecHitProducerGPU #44595
move DataRecord includes to HBHERecHitProducerGPU #44595
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44595/39772
|
A new Pull Request was created by @dan131riley for master. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61f0a0/38561/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
please test for el9_amd64_gcc13 though build will fail due to other errors in gcc13 IBs but lets just check if nvcc build errors are gone |
-1 Failed Tests: Build BuildI found compilation error when building: /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02831/el9_amd64_gcc13/external/gcc/13.2.0-1b0a3367d04f48f01ad3ccf40e55475c/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.2.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lRecoLocalCaloHcalRecAlgos: No such file or directory /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02831/el9_amd64_gcc13/external/gcc/13.2.0-1b0a3367d04f48f01ad3ccf40e55475c/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.2.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lDataFormatsTrackReco: No such file or directory /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02831/el9_amd64_gcc13/external/gcc/13.2.0-1b0a3367d04f48f01ad3ccf40e55475c/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.2.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lDataFormatsTrackCandidate: No such file or directory /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02831/el9_amd64_gcc13/external/gcc/13.2.0-1b0a3367d04f48f01ad3ccf40e55475c/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.2.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lDataFormatsTrajectorySeed: No such file or directory /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02831/el9_amd64_gcc13/external/gcc/13.2.0-1b0a3367d04f48f01ad3ccf40e55475c/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.2.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lDataFormatsTrackingRecHit: No such file or directory collect2: error: ld returned 1 exit status gmake: *** [tmp/el9_amd64_gcc13/src/RecoLocalCalo/HcalRecProducers/src/RecoLocalCaloHcalRecProducers/libRecoLocalCaloHcalRecProducers.so] Error 1 Leaving library rule at RecoLocalCalo/HcalRecProducers >> Leaving Package RecoLocalCalo/HcalRecProducers >> Package RecoLocalCalo/HcalRecProducers built >> Subsystem RecoLocalCalo built |
|
+1 |
@kakwok FYI (although should not really impact the Alpaka porting) |
PR description:
This PR fixes a problem with the includes made visible to nvcc in RecoLocalCalo/HcalRecProducers. nvcc is normally not supposed to be exposed to EventSetup records. In this case, this is leading to compilation errors in the gcc13 IBs where nvcc does not support all the intrinsic builtins used by gcc13. Details in #44583.
This PR simply moves some DataRecord includes to a narrower scope where nvcc won't be exposed.
PR validation:
Compiles with gcc13. Purely technical fix.