move DataRecord includes to HBHERecHitProducerGPU

[dan131riley]

PR description:

This PR fixes a problem with the includes made visible to nvcc in RecoLocalCalo/HcalRecProducers. nvcc is normally not supposed to be exposed to EventSetup records. In this case, this is leading to compilation errors in the gcc13 IBs where nvcc does not support all the intrinsic builtins used by gcc13. Details in #44583.

This PR simply moves some DataRecord includes to a narrower scope where nvcc won't be exposed.

PR validation:

Compiles with gcc13. Purely technical fix.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44595/39772

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @dan131riley for master.

It involves the following packages:

• RecoLocalCalo/HcalRecProducers (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@abdoulline, @bsunanda, @apsallid, @youyingli, @mariadalfonso, @missirol this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61f0a0/38561/summary.html
COMMIT: e744cd0
CMSSW: CMSSW_14_1_X_2024-04-02-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44595/38561/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 58 lines to the logs
• Reco comparison results: 48 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3304819
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3304796
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

please test for el9_amd64_gcc13

though build will fail due to other errors in gcc13 IBs but lets just check if nvcc build errors are gone

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61f0a0/38567/summary.html
COMMIT: e744cd0
CMSSW: CMSSW_14_1_X_2024-04-01-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44595/38567/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02831/el9_amd64_gcc13/external/gcc/13.2.0-1b0a3367d04f48f01ad3ccf40e55475c/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.2.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lRecoLocalCaloHcalRecAlgos: No such file or directory
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02831/el9_amd64_gcc13/external/gcc/13.2.0-1b0a3367d04f48f01ad3ccf40e55475c/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.2.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lDataFormatsTrackReco: No such file or directory
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02831/el9_amd64_gcc13/external/gcc/13.2.0-1b0a3367d04f48f01ad3ccf40e55475c/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.2.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lDataFormatsTrackCandidate: No such file or directory
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02831/el9_amd64_gcc13/external/gcc/13.2.0-1b0a3367d04f48f01ad3ccf40e55475c/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.2.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lDataFormatsTrajectorySeed: No such file or directory
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02831/el9_amd64_gcc13/external/gcc/13.2.0-1b0a3367d04f48f01ad3ccf40e55475c/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.2.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lDataFormatsTrackingRecHit: No such file or directory
collect2: error: ld returned 1 exit status
gmake: *** [tmp/el9_amd64_gcc13/src/RecoLocalCalo/HcalRecProducers/src/RecoLocalCaloHcalRecProducers/libRecoLocalCaloHcalRecProducers.so] Error 1
Leaving library rule at RecoLocalCalo/HcalRecProducers
>> Leaving Package RecoLocalCalo/HcalRecProducers
>> Package RecoLocalCalo/HcalRecProducers built
>> Subsystem RecoLocalCalo built


[smuzaffar]

nvcc build errors for gcc13 are fixed

[antoniovilela]

+1

[makortel]

@kakwok FYI (although should not really impact the Alpaka porting)