Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to target version 3.1.0 of Chocolatey.NuGet.Client assemblies #508

Closed
ferventcoder opened this issue Dec 16, 2015 · 32 comments · Fixed by #3013
Closed

Upgrade to target version 3.1.0 of Chocolatey.NuGet.Client assemblies #508

ferventcoder opened this issue Dec 16, 2015 · 32 comments · Fixed by #3013
Assignees
@AdmiringWorm @TheCakeIsNaOH
Labels
5 - Released Improvement
Milestone
2.0.0

Comments

@ferventcoder
Copy link
Member

ferventcoder commented Dec 16, 2015 •
edited by gep13
Loading

NuGet/Home#1839

Upgrade NuGet.Core to a version that better handles conflict resolution

May fix #507
May fix #227
May fix #116
May fix #1158
Relates to #2592 - support for embedded icons

References
@ferventcoder ferventcoder self-assigned this Dec 16, 2015
@ferventcoder ferventcoder added this to the 0.9.10 milestone Dec 16, 2015
@ferventcoder
Copy link
Member Author

NuGet/Home#1870

@ferventcoder ferventcoder mentioned this issue Dec 30, 2015
Closed
@ferventcoder
Copy link
Member Author

ferventcoder commented Jan 5, 2016 •
edited
Loading

This will require .NET 4.5 for the upgrade to a v3 version of NuGet so this will need to move to 0.9.11 0.11.0 where we are eclipsing support for .NET 4 (and Windows 2003).

@ferventcoder ferventcoder modified the milestones: 0.9.11, 0.9.10 Jan 5, 2016
@ferventcoder ferventcoder mentioned this issue May 16, 2016
Open
@timbrown5
Copy link

Hi ferventcoder,
I know it's a bit early (as 0.9.10 has only just been released) but I was wondering if you have an estimate for when this work might be started. It would be good to test if this fixes the issues I was having (even if it's a development build).

@ferventcoder
Copy link
Member Author

It is definitely a bit early. No estimate yet on this.

@ferventcoder ferventcoder mentioned this issue Mar 18, 2017
Closed
@timbrown5
Copy link

Just wondered if there is any update on when this might be fixed?

@ferventcoder
Copy link
Member Author

Looking at late 2017 depending on where it falls in prioritization. Right now it is a few back on the list. We have a pretty aggressive schedule so it could be done in 2017 but it may fall back to 2018.

@ferventcoder ferventcoder mentioned this issue May 27, 2017
Closed
@ferventcoder ferventcoder mentioned this issue Aug 3, 2017
Open
@timbrown5
Copy link

Hi @ferventcoder,
Is there any update on this?
Thanks,
Tim

@ferventcoder
Copy link
Member Author

@timbrown5 Note the Milestone - that gives you the best idea on where things are. It's definitely scheduled, but priorities shift based on customer needs, etc.

@eriviere
Copy link

What is the current version of NuGet used by Chocolatey?
I am unable to install a NuGet Package because it believes I am using version 2.11 of Nuget. I am actually using choco version 0.10.11

The error is this one:

The 'Microsoft.NETCore.Platforms 2.0.2' package requires NuGet client version '2.12' or above, but the current NuGet version is '2.11.0.0'.

@ferventcoder
Copy link
Member Author

@eriviere Chocolatey in what version? It is 2.11, but we're moving it up to 2.14 soon. Hopefully that will make the move up to v3 better.

@ferventcoder ferventcoder mentioned this issue Jan 18, 2019
Closed
@ferventcoder ferventcoder mentioned this issue Feb 5, 2019
Open
@ferventcoder ferventcoder mentioned this issue May 26, 2019
Open
@ferventcoder ferventcoder mentioned this issue Aug 3, 2019
Open
@ferventcoder ferventcoder changed the title Upgrade NuGet.Core to a version that better handles conflict resolution Upgrade NuGet.Core to v3/v4 Jun 24, 2020
@ferventcoder ferventcoder mentioned this issue Jun 24, 2020
Open
@AdmiringWorm AdmiringWorm mentioned this issue May 10, 2023
Merged
10 tasks
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue May 10, 2023
@AdmiringWorm
(chocolatey#508) Update snapshot service to respect version normaliza…
6694074 
…tion

This commit updates the file snapshot service to honor version normalization
with fallbacks to old version methods.

This is done as we are moving towards normalizing version numbers in most of
the code, which causes a conflict when installing, upgrading or uninstalling
packages that sometimes it would use non-normalized version number,
and other times it would use normalized version numbers.
Now with this change it will prefer to use normalized version number, but will
continue to read/update package versions that was installed using
non-normalized version numbers.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue May 10, 2023
@AdmiringWorm
(chocolatey#508) Remove nupkg file on partial file removals
9e0d81b 
This commit updates the uninstall process to ensure that the nupkg
file is removed, even in the cases where only partial file removals has
happened. This will prevent the package from being listed as installed
when partial removal is done.

While the original code does not pose any problems with normal usage
of CLI, it will not remove the nuget packages when the package has been
modified, like what Licensed Extension does when optimizing installations.
corbob pushed a commit to AdmiringWorm/choco that referenced this issue May 10, 2023
@AdmiringWorm @corbob
(chocolatey#508) Update snapshot service to respect version normaliza…
20d6dc1 
…tion

This commit updates the file snapshot service to honor version normalization
with fallbacks to old version methods.

This is done as we are moving towards normalizing version numbers in most of
the code, which causes a conflict when installing, upgrading or uninstalling
packages that sometimes it would use non-normalized version number,
and other times it would use normalized version numbers.
Now with this change it will prefer to use normalized version number, but will
continue to read/update package versions that was installed using
non-normalized version numbers.
corbob pushed a commit to AdmiringWorm/choco that referenced this issue May 10, 2023
@AdmiringWorm @corbob
(chocolatey#508) Remove nupkg file on partial file removals
797cdf9 
This commit updates the uninstall process to ensure that the nupkg
file is removed, even in the cases where only partial file removals has
happened. This will prevent the package from being listed as installed
when partial removal is done.

While the original code does not pose any problems with normal usage
of CLI, it will not remove the nuget packages when the package has been
modified, like what Licensed Extension does when optimizing installations.
vexx32 added a commit that referenced this issue May 10, 2023
@vexx32
Merge pull request #3151 from AdmiringWorm/PROJ-629/file-removal
8e00b25 
(#508) Fix some files not being removed during uninstall/upgrade
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue May 15, 2023
@AdmiringWorm
(chocolatey#508) Do case insensitive comparison on package ids
d8aba57 
This commit updates the Equals comparisons in the nuget
service to be cake insensitive.

This is done as without this change the user will always
have to pass in the identifier in the exact casing that
is returned from the nuget server, causing issues especially
during upgrade scenarios.

Additionally, Equals and Compare methods has been added
to the banned API list to prevent the use
of these without specifying a StringComparison.
@AdmiringWorm AdmiringWorm mentioned this issue May 15, 2023
Merged
10 tasks
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue May 15, 2023
@AdmiringWorm
(chocolatey#508) Do case insensitive comparison on package ids
42fbab6 
This commit updates the Equals comparisons in the nuget
service to be case insensitive.

This is done as without this change the user will always
have to pass in the identifier in the exact casing that
is returned from the nuget server, causing issues especially
during upgrade scenarios.

Additionally, Equals and Compare methods has been added
to the banned API list to prevent the use
of these without specifying a StringComparison.
gep13 pushed a commit to AdmiringWorm/choco that referenced this issue May 15, 2023
@AdmiringWorm @gep13
(chocolatey#508) Do case insensitive comparison on package ids
952d6e2 
This commit updates the Equals comparisons in the nuget
service to be case insensitive.

This is done as without this change the user will always
have to pass in the identifier in the exact casing that
is returned from the nuget server, causing issues especially
during upgrade scenarios.

Additionally, Equals and Compare methods has been added
to the banned API list to prevent the use
of these without specifying a StringComparison.
gep13 added a commit that referenced this issue May 15, 2023
@gep13
Merge pull request #3157 from AdmiringWorm/casing-fixes
e4c9fb6 
(#508) Do case insensitive comparison on package ids
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue May 15, 2023
@AdmiringWorm
(chocolatey#508) Replace resource tuple with new resource class
e63baf8 
This commit removes any uses of the custom public tuple
method, and replaces all its uses with the new Resource
endpoint class that caches previously used endpoints.
@AdmiringWorm AdmiringWorm mentioned this issue May 15, 2023
Merged
10 tasks
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue May 15, 2023
@AdmiringWorm
(chocolatey#508) Fix v3 feeds mixed with v2 feeds not finding packages
f045f6b 
This commit updates the FindPackage method we use when installing
and acquiring information about a package to properly handle feeds
when there is a mix of feeds that support v2 odata queries, and when
there is one or more feeds that only support v3 feeds without the fallback
to v2 odata APIs.
gep13 added a commit that referenced this issue May 16, 2023
@gep13
Merge pull request #3159 from AdmiringWorm/multi-feed-list-fix
238bd2e 
(#508) Fix v3 feeds mixed with v2 feeds not finding packages
gep13 added a commit that referenced this issue May 17, 2023
@gep13
(#508) Ensure correct configuration object is used
f7a5e47 
When we first brought in the new NuGet.Client, a change was made to how
the callback for the HandlePackageResult was done.  Previously, this
didn't receive a ChocolateyConfiguration object from the callback, but
then it did.  As a result, the wrong instance of the
ChocolateyConfiguration object was sent along to continue the
operation, which meant all the environment information had not been set
correctly.  This caused a problem when trying to install the cygwin
package since there is a check against what operating system the
process is being run on, which hadn't been set correctly.

This came up when running choco install chere --source cygwin, which
failed to install Cygwin correctly.  This change has been in the code
base a while, and it was only when testing the installation of a
package from an alternative source that this came up.
corbob added a commit that referenced this issue May 19, 2023
@corbob
Merge branch 'release/2.0.0'
89c8c9c 
* release/2.0.0: (422 commits)
  (maint) Update Chocolatey.NuGet.Client version
  (build) Update GRM Template to add full stop.
  (build) Update GRM config for BuildAutomation tag
  (#508) Ensure correct configuration object is used
  (tests) Use nuspec for version normalization tests
  (tests) Tag version normalization Pester tests
  (#158) Restore --source in tab completion for list
  (#158) Refactoring based on pairing session
  (#158) Restore --source for choco list
  (maint) Add vscode settings file
  (maint) Changes during pairing session
  (tests) Add non-normalized version Pester tests
  (maint) Update testing vagrant for granular runs
  (maint) Update Pester test for Pester v5 norms
  (#1174) Add non-normalized packages for tests
  (#508) Fix v3 feeds mixed with v2 feeds not finding packages
  (#508) Do case insensitive comparison on package ids
  (maint) Remove prerelease warnings from the nuspec
  (maint/doc) Amend GenerateDocs for list/search split
  (#2902) Ensure PowerShell tasks use SystemDefault TLS
  ...
@gep13 gep13 changed the title Upgrade to target version 6.4.0 of NuGet.Client assemblies Upgrade to target version 3.1.0 of Chocolatey.NuGet.Client assemblies May 19, 2023
@AdmiringWorm AdmiringWorm mentioned this issue May 24, 2023
Merged
10 tasks
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

gep13 added a commit that referenced this issue May 31, 2023
@gep13
Merge branch 'master' into develop
cff06ee 
* master: (148 commits)
  (#948) Add user as sensitive argument
  (#158) Error on list -lo without -r
  (doc) Update description of page-size argument
  (#158) Restore -lo warning when not using -r
  (#158) Update tests
  (#158) Relegate the -lo warning to log-file-only
  (#3165) Update count method to support nuget service
  (maint) Update Chocolatey.NuGet.Client version
  (build) Update GRM Template to add full stop.
  (build) Update GRM config for BuildAutomation tag
  (#508) Ensure correct configuration object is used
  (tests) Use nuspec for version normalization tests
  (tests) Tag version normalization Pester tests
  (#158) Restore --source in tab completion for list
  (#158) Refactoring based on pairing session
  (#158) Restore --source for choco list
  (maint) Add vscode settings file
  (maint) Changes during pairing session
  (tests) Add non-normalized version Pester tests
  (maint) Update testing vagrant for granular runs
  ...
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jun 16, 2023
@TheCakeIsNaOH
(chocolatey#508) Make package id comparisons case insensitive
836b81d 
This helps ensure that package IDs are handled in a case
insensitive manner.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jun 20, 2023
@TheCakeIsNaOH
(chocolatey#508) Make package id comparisons case insensitive
4dae78a 
This helps ensure that package IDs are handled in a case
insensitive manner.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jul 1, 2023
@TheCakeIsNaOH
(chocolatey#508) Make package id comparisons case insensitive
10072aa 
This helps ensure that package IDs are handled in a case
insensitive manner.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Aug 9, 2023
@TheCakeIsNaOH
(chocolatey#508) Make package id comparisons case insensitive
a97dc30 
This helps ensure that package IDs are handled in a case
insensitive manner.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 9, 2024
@TheCakeIsNaOH
(chocolatey#508) Make package id comparisons case insensitive
ecaaf15 
This helps ensure that package IDs are handled in a case
insensitive manner.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Apr 28, 2024
@TheCakeIsNaOH
(chocolatey#508) Make package id comparisons case insensitive
edd1f23 
This helps ensure that package IDs are handled in a case
insensitive manner.
gep13 pushed a commit to gep13/choco that referenced this issue Sep 25, 2024
@TheCakeIsNaOH @gep13
(chocolatey#508) Make package id comparisons case insensitive
86c257e 
This helps ensure that package IDs are handled in a case
insensitive manner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdmiringWorm AdmiringWorm

@TheCakeIsNaOH TheCakeIsNaOH

Labels
5 - Released Improvement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

(#508) Fix force dependencies to not remove existing non-dependency packages corbob/choco