(#3165) Update count method to support nuget service #3166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the Count method that is used to get the amount of packages available on normal and alternative sources to include support for the nuget service. During a previous refactor we had removed the support of acquiring packages on normal sources by a mistake, which causes an issue with Chocolatey GUI to fail due to no available source runner can be found when dealing with counting packages. This was fixed by including an explicit call to the nuget service when norrmal sources are being used.
AdmiringWorm
force-pushed
the
count-nuget-service
branch
from
a622260 to
159ee69
Compare
AdmiringWorm
changed the title
vexx32
approved these changes
May 24, 2023
|
Thanks for getting this fixed up @AdmiringWorm 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
The changes in this pull request reintroduces the ability to get the amount of packages available on remote and local nuget sources, which had been overlooked during a previous refactor.
Motivation and Context
Without the changes made in this PR it will cause Chocolatey GUI to not function properly when it tries to get packages from remote and local sources configured in
chocolatey.config.When this is attempted Chocolatey GUI would crash with an exception that a normal source runner could not be found (due to NuGetService not being seen as a source runner anymore).
Testing
Get-ChocoUpdatedDebugVersion.ps1 -ChocoSourceLocation "<PATH_TO_CLONED_PR_CHANGES>".Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
choco listto be local only #158