choco uninstall all does not honor dependencies

[mkevenaar]

What You Are Seeing?

choco uninstall all -y uninstalling all on alphabet

What is Expected?

Uninstalling honoring the dependencies

How Did You Get This To Happen? (Steps to Reproduce)

NOTE Only try this on the chocolatey-test-environment or a test machine!

1. choco install ci-cd-assets-vscode
2. choco uninstall all -y

I would expect that it would uninstall

1. ci-cd-assets-vscode
2. chocolatey-vscode.extension
3. vscode

Actual order is 2,1,3 (including chocolatey, as expected)

[ferventcoder]

Does it error when it goes the wrong way?

[mkevenaar]

@ferventcoder as choco currently first uninstalls the extension, the POSH module and it’s commands are removed before the uninstallation of the vscode add-on package.

In the add-on uninstaller, the one of the POSH module commandlets is used to remove the add-on from vscode.

[mkevenaar]

@ferventcoder I’ll try to make a gist soon.

[mkevenaar]

@ferventcoder https://gist.github.com/mkevenaar/9461720e59305b0b6602bda880fe2147

On line 554 you'll see the error message that Uninstall-VsCodeExtension is not found. It has been uninstalled on line 329.

/cc: @gep13

[ferventcoder]

Oh I think I understand. The packages required extensions in other packages that were removed first. So I don't think NuGet supports dependency order by default - you can force dependencies on uninstall if you want it to attempt proper order.

[mkevenaar]

@ferventcoder When you have things setup as mentioned above, and try to run choco uninstall vscode The installation tells you that you can't uninstall vscode as ci-cd-assets-vscode depends on it.

[ferventcoder]

When you have things setup as mentioned above, and try to run choco uninstall vscode The installation tells you that you can't uninstall vscode as ci-cd-assets-vscode depends on it.

@mkevenaar that is correct behavior. You need to uninstall things in the proper order. Which is about what this issue is. What happens if you run choco uninstall ci-cd-assets-vscode --force-dependencies?

[mkevenaar]

@ferventcoder that was not the point I was trying to make here.
I have given one example where I know it would go wrong when running choco uninstall all

I think this might be the location of the problem:

choco/src/chocolatey/infrastructure.app/services/NugetService.cs

Lines 1441 to 1447 in 17f00eb

	set_package_names_if_all_is_specified(config, () =>
	{
	// force remove the item, ignore the dependencies
	// as those are going to be picked up anyway
	config.Force = true;
	config.ForceDependencies = false;
	});

[ferventcoder]

Do you think removing the force dependencies would work? Something we could do without #508

[mkevenaar]

I think this needs to be tested, but it might work.

[VishalJadav]

Solution:

When you specify "all", chocolatey grabs packages from here:

choco/src/chocolatey/infrastructure.app/services/NugetService.cs

Line 1686 in 17f00eb

private void set_package_names_if_all_is_specified(ChocolateyConfiguration config, Action customAction)

choco/src/chocolatey/infrastructure.app/services/NugetService.cs

Line 1690 in 17f00eb

var packagesToUpdate = get_all_installed_packages(config).Select(p => p.Name).ToList();

The list "packagesToUpdate" needs to be ordered according to dependency flow. This can be done via Topological sorting using depth-first search (DFS) algorithm.