Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons on fileshare repo #2592

Closed
barjonas opened this issue Feb 9, 2022 · 3 comments
Closed

Icons on fileshare repo #2592

barjonas opened this issue Feb 9, 2022 · 3 comments

Comments

@barjonas
Copy link

barjonas commented Feb 9, 2022

I'm starting on my Chocolatey journey by using a shared directory as a repository. I have an install script which adds this repository using an environment variable and build scripts which push to the repository in the same way. The literal URL could end up varying between machines. This does not appear to leave any option for hosting icons. <iconUrl> does not support relative paths. That element is deprecated in the latest nuspec spec anyway, but choco does not appear to support the newer <icon> element. If it did, it could be a great solution to my particular scenario.

I can see how this would add complexity to the tooling. The web repository would have to know how to maintain its own cache, and each client probably would too. But, on the other hand, part of the attraction to a package manager is their self-contained nature. This would make for more deterministic behavior than relying on multiple external CDNs etc. It would also make the documentation much simpler.

@gep13
Copy link
Member

gep13 commented Feb 10, 2022

@barjonas Chocolatey forked the nuspec format that is used, so we don't follow along exactly with what NuGet.exe (the link that you provided does), so just because iconUrl is deprecated there, doesn't mean that it is deprecated in choco.exe.

The ability to support embedded icons in a package is definitely something that we want to have, but as you say, this is something that will require changes both from a repository (community.chocolatey.org) stand point, as well as within choco.exe as well.

We have a tracking issue regarding the upgrade to the latest NuGet assemblies, which will likely encompass the ability to use embedded icons:

#508

Can I suggest that you follow that issue for updates on this.

For now, I am going to close out this issue.

@ryanrichter94 this is another example of why we need this: chocolatey/docs#374

@Schroedingers-Cat
Copy link

We have a tracking issue regarding the upgrade to the latest NuGet assemblies, which will likely encompass the ability to use embedded icons:

#508

@gep13 with the referenced issue closed by v2.0, can we now use embedded icons?

@pauby
Copy link
Member

pauby commented Mar 2, 2024

@gep13 with the referenced issue closed by v2.0, can we now use embedded icons?

Embedded icons are not supported. There is no timescale for when it will be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants