(#508) Fix force dependencies to not remove existing non-dependency packages #3013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the integration test scenarios for install scenario to ensure that forcing reinstallation does not erroneously remove any existing packages.
When forcing dependencies, we need to ensure that we're only giving the dependencies to the service to force reinstallation. This updates the logic to only get the packages that are dependencies.
Remove the broken tag from the force dependencies pester tests as this scenario has been fixed.
|
Opened PR as a Draft while the Test Kitchen tests run. Once they're done, will mark as ready. |
|
@corbob thanks for getting this fixed up! Will move forward with the merge, even though the Mac build here is failing. This build started failing as a result of another change, and I haven't had a chance to look into this yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
When forcing dependency reinstallations, don't mark local non-dependency packages as requiring uninstall/reinstall.
Motivation and Context
When doing
choco install hasdependencies --force --forcedependenciesChocolatey would mark all local packages for uninstallation and reinstallation. It would then remove the local packages, but fail to reinstall any that weren't dependencies.Testing
Operating Systems Testing
Change Types Made
Change Checklist
Related Issue