Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Disable Reset button if there are no changes done to portfolio settings #7944

Closed
srirambv opened this issue Aug 24, 2023 · 1 comment · Fixed by #7950
Closed

Disable Reset button if there are no changes done to portfolio settings #7944

srirambv opened this issue Aug 24, 2023 · 1 comment · Fixed by #7950
Assignees
@StephenHeaps
Labels
enhancement Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/exclude
Milestone
1.57

Comments

@srirambv
Copy link
Contributor

Description:

Disable Reset button if there are no changes done to portfolio settings

Steps to Reproduce

  1. Create a new wallet or restore one
  2. Open Portfolio settings
  3. Reset is enabled without having changed any settings

Actual result:

Reset button is enabled without changing any settings

Expected result:

Disable Reset button if there are no changes done to portfolio settings

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easy

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? NA
  • Can you reproduce this issue with the current build from AppStore? NA

Device details:

All

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information

cc: @nuo-xu @StephenHeaps
@srirambv srirambv added this to Web3 Aug 24, 2023
@srirambv srirambv mentioned this issue Aug 24, 2023
Closed
@StephenHeaps StephenHeaps self-assigned this Aug 24, 2023
@StephenHeaps StephenHeaps moved this to In Progress in Web3 Aug 24, 2023
@srirambv srirambv mentioned this issue Aug 24, 2023
Closed
@StephenHeaps StephenHeaps mentioned this issue Aug 24, 2023
Merged
11 tasks
@StephenHeaps StephenHeaps added this to the 1.57 milestone Aug 24, 2023
@StephenHeaps StephenHeaps moved this from In Progress to In Review in Web3 Aug 24, 2023
StephenHeaps added a commit that referenced this issue Aug 24, 2023
@StephenHeaps
Fix #7947, #7944, #7948, #7946: Portfolio Fixes (#7950)
98c7464 
* Hide/Remove Filecoin accounts from Portfolio & NFT filters until they are supported.

* Fix `Network Logo` and `Hide Unowned` NFT Filters & Display Settings toggles not resetting to defaults when `Reset` tapped

* Disable `Reset` button on Filters & Display Settings when filters are showing defaults.

* Fix Filters & Display Settings Picker text truncated, janky animation when switching selection.
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Aug 24, 2023
StephenHeaps added a commit that referenced this issue Aug 24, 2023
@StephenHeaps
Fix #7947, #7944, #7948, #7946: Portfolio Fixes (#7950)
c5a8cdb 
* Hide/Remove Filecoin accounts from Portfolio & NFT filters until they are supported.

* Fix `Network Logo` and `Hide Unowned` NFT Filters & Display Settings toggles not resetting to defaults when `Reset` tapped

* Disable `Reset` button on Filters & Display Settings when filters are showing defaults.

* Fix Filters & Display Settings Picker text truncated, janky animation when switching selection.
@srirambv
Copy link
Contributor Author

Verification passed on iPhone 13 with iOS 16.6 running 1.53 (23.8.28.22)

  • Verified steps from issue description
  • Verified Reset button is not enabled by default
  • Verified Reset button works as expected when a setting is changed
7944.MP4

arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#7947, brave/brave-ios#7944, brave/brave-ios#7948, b…
40d28b4 
…rave/brave-ios#7946: Portfolio Fixes (brave/brave-ios#7950)

* Hide/Remove Filecoin accounts from Portfolio & NFT filters until they are supported.

* Fix `Network Logo` and `Hide Unowned` NFT Filters & Display Settings toggles not resetting to defaults when `Reset` tapped

* Disable `Reset` button on Filters & Display Settings when filters are showing defaults.

* Fix Filters & Display Settings Picker text truncated, janky animation when switching selection.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
enhancement Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.57
Development

Successfully merging a pull request may close this issue.

Fix #7947, #7944, #7948, #7946: Portfolio Fixes brave/brave-ios
2 participants
@StephenHeaps @srirambv