Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Portfolio Filters Empty State(s) #7618

Closed
StephenHeaps opened this issue Jun 19, 2023 · 1 comment · Fixed by #7826
Closed

Portfolio Filters Empty State(s) #7618

StephenHeaps opened this issue Jun 19, 2023 · 1 comment · Fixed by #7826
Assignees
@StephenHeaps
Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.57

Comments

@StephenHeaps
Copy link
Contributor

StephenHeaps commented Jun 19, 2023 •
edited
Loading

Description:

Title: No available assets
Description: Deposit or purchase tokens to get started. If you don't see tokens from an imported account, check the filters and display settings. Unknown tokens may need to be added as custom assets.

https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1686939237810999
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jun 30, 2023
@StephenHeaps StephenHeaps changed the title Network Filter Empty State Filters Empty State(s) Jul 13, 2023
@StephenHeaps StephenHeaps changed the title Filters Empty State(s) Portfolio/NFT Filters Empty State(s) Jul 21, 2023
@StephenHeaps StephenHeaps self-assigned this Aug 2, 2023
@StephenHeaps StephenHeaps mentioned this issue Aug 3, 2023
Merged
11 tasks
@StephenHeaps StephenHeaps changed the title Portfolio/NFT Filters Empty State(s) Portfolio Filters Empty State(s) Aug 3, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Web3 Aug 11, 2023
StephenHeaps added a commit that referenced this issue Aug 11, 2023
@StephenHeaps
Fix #7765, Fix #7618: Portfolio Group By filter & Empty State (#7826)
79d46fb 
* Support Group By Filter & Display Setting in Portfolio

* Update PortfolioStoreTests to test each filter separately, add tests for grouping by accounts and grouping by networks

* Add empty state, loading state to Portfolio Assets

* Sort order of 0 balance assets can change when tapping save filters without changing filters.

* Update `Hide Small Balances` threshold from $1 to $0.05.
Update logic so groups with no balance are only hidden when `Hide Small Balances` is enabled

* Add new `WalletDisclosureGroup` replacement for `DisclosureGroup` which uses `leo.carat.down` for the expand button and has no indent. Fix group sorting for iOS 16.4 ..< iOS 17
@iccub iccub added this to the 1.57 milestone Aug 16, 2023
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.57 (23.8.23.20)

  • Verified steps from #7826
  • Verified able to group assets by accounts or networks
  • Verified able to sort asset based on balance High to low/low to high
  • Verified able to sort asset in ascending (A to Z) or descending (Z to A)
  • Verified able to hide tokens with < 0.5 balance
  • Verified able to filter portfolio by specific account
  • Verified able to filter portfolio by specific network
  • Verified saved settings is retained between browser restarts
  • Encountered #7942, #7943, #7944, #7945, #7946
iPhone 7+ (iOS 15.7.8) iPhone 13 (iOS 16.6) iPad Pro (iOS 16.6)
7618-iPhone.7+.MP4
7618-iPhone.13.MP4
7618-iPad.Pro.MP4

@srirambv srirambv mentioned this issue Aug 24, 2023
Closed
@Uni-verse Uni-verse mentioned this issue Nov 11, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#7765, Fix brave/brave-ios#7618: Portfolio Group B…
28b2ce7 
…y filter & Empty State (brave/brave-ios#7826)

* Support Group By Filter & Display Setting in Portfolio

* Update PortfolioStoreTests to test each filter separately, add tests for grouping by accounts and grouping by networks

* Add empty state, loading state to Portfolio Assets

* Sort order of 0 balance assets can change when tapping save filters without changing filters.

* Update `Hide Small Balances` threshold from $1 to $0.05.
Update logic so groups with no balance are only hidden when `Hide Small Balances` is enabled

* Add new `WalletDisclosureGroup` replacement for `DisclosureGroup` which uses `leo.carat.down` for the expand button and has no indent. Fix group sorting for iOS 16.4 ..< iOS 17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.57
Development

Successfully merging a pull request may close this issue.

Fix #7765, Fix #7618: Portfolio Group By filter & Empty State brave/brave-ios
3 participants
@StephenHeaps @iccub @srirambv