Fix #7765, Fix #7618: Portfolio Group By filter & Empty State

[StephenHeaps]

Summary of Changes

• Implements the Group By filter with none (default), accounts and networks grouping options.
• Implements loading state when loading balances.
  • Loading state is only shown if hiding small balances, OR assets are grouped (groups with 0 total balance are hidden)

This pull request fixes #7765, fixes #7618

Submitter Checklist:

• Unit Tests are updated to cover new or changed functionality
• User-facing strings use NSLocalizableString()
• New or updated UI has been tested across:
  • Light & dark mode
  • Different size classes (iPhone, landscape, iPad)
  • Different dynamic type sizes

Test Plan:

1. Open Wallet Portfolio, it should not be grouped by default.
2. Tap Filters & Display Settings button and then tap Reset
3. Verify default Group By option is None.
4. Change Group By to accounts and tap Save Changes.
5. Verify Portfolio is now grouped by each account, with the assets below showing the balance only for that account.
   • Note: Groups with 0 total balance are hidden automatically if Hide Small Balances is enabled.
6. Verify groups are sorted by fiat value.
7. Tap Filters & Display Settings button, then de-select some accounts and tap Save Changes
8. Verify de-selected account groups are no longer shown.
9. Tap Filters & Display Settings button then tap Reset (re-selects all accounts again), then change Group By to Networks and tap Save Changes
10. Verify Portfolio is now grouped by each network with only assets for that network shown in each group.
    • Note: Groups with 0 total balance are hidden automatically if Hide Small Balances is enabled.
11. Verify groups are sorted by fiat value.
12. Tap Filters & Display Settings button then tap Reset.
13. De-select all accounts, or all networks and tap Save Changes.
14. Verify empty state is shown.
    • Empty state should be shown whenever no assets are displayed. This can occur with many combinations, for example hiding small balances, grouping assets and then hiding accounts with balances or hiding networks with balances, etc.
15. Close the wallet, or quit Brave. Re-open Portfolio and verify Group By filter is preserved.

Screenshots:

portfolio.grouping.mp4

Reviewer Checklist:

• Issues include necessary QA labels:
  • QA/(Yes|No)
  • bug / enhancement
• Necessary security reviews have taken place.
• Adequate unit test coverage exists to prevent regressions.
• Adequate test plan exists for QA to validate (if applicable).
• Issue and pull request is assigned to a milestone (should happen at merge time).

[nuo-xu]

is it possible to substitute the disclosure symbol?

Current	Similar in Wallet	Desktop

[nuo-xu]

once assets are grouped, some rows have a divider but some don't (in the screenshot, there is no divider under Wrapped Ether) maybe related to the padding of each row.

[nuo-xu]

want to mention here again.

Note: Groups with 0 total balance are hidden automatically.

looks like a bug. wdyt? cc @jamesmudgett @srirambv

[nuo-xu]

not sure if this is what we want. but its a minor issue.
for assets with zero balance will be re-ordered (core-data doesn't gives same order), if i tap save changes with no actual changes.
https://github.com/brave/brave-ios/assets/1187676/d52fa84a-026e-4535-9799-734f0b3ffc86

[StephenHeaps]

is it possible to substitute the disclosure symbol?

Add a custom WalletDisclosureGroup for this as DisclosureGroupStyle is iOS 16+. a94a5dd

once assets are grouped, some rows have a divider but some don't (in the screenshot, there is no divider under Wrapped Ether) maybe related to the padding of each row.

Padding and separator issue should be resolved now.

want to mention here again.
Note: Groups with 0 total balance are hidden automatically.
looks like a bug. wdyt?

Groups are now only hidden here now when Hide Small Balances is enabled. eac4c70

not sure if this is what we want. but its a minor issue.
for assets with zero balance will be re-ordered (core-data doesn't gives same order), if i tap save changes with no actual changes.

Updated sort logic when sorting empty balances by value to move native token(s) to top of list, otherwise will sort alphabetically when 2+ assets have 0 balance 92eadf2.

[nuo-xu]

all my comments have been addressed. Portfolio looks pretty awesome now! good work here!