Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Support Portfolio Group By Filter #7765

Closed
StephenHeaps opened this issue Jul 21, 2023 · 1 comment · Fixed by #7826
Closed

Support Portfolio Group By Filter #7765

StephenHeaps opened this issue Jul 21, 2023 · 1 comment · Fixed by #7826
Assignees
@StephenHeaps
Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.57

Comments

@StephenHeaps
Copy link
Contributor

Description:

Support Group by filter in Portfolio.
Title: Group by
Description: Group assets by
Options: None (default), Accounts, Networks

If a group has no tokens visible (after other filters are applied), it should be hidden. Ex. Hiding small balances & grouping by account, an account group with no balance for any token would be hidden.

Portfolio v2 designs have grouping support, if done with Portfolio v1 use section grouping.
@StephenHeaps StephenHeaps self-assigned this Jul 21, 2023
@StephenHeaps StephenHeaps moved this to In Progress in Web3 Jul 24, 2023
@StephenHeaps StephenHeaps mentioned this issue Aug 3, 2023
Merged
11 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Aug 11, 2023
StephenHeaps added a commit that referenced this issue Aug 11, 2023
@StephenHeaps
Fix #7765, Fix #7618: Portfolio Group By filter & Empty State (#7826)
79d46fb 
* Support Group By Filter & Display Setting in Portfolio

* Update PortfolioStoreTests to test each filter separately, add tests for grouping by accounts and grouping by networks

* Add empty state, loading state to Portfolio Assets

* Sort order of 0 balance assets can change when tapping save filters without changing filters.

* Update `Hide Small Balances` threshold from $1 to $0.05.
Update logic so groups with no balance are only hidden when `Hide Small Balances` is enabled

* Add new `WalletDisclosureGroup` replacement for `DisclosureGroup` which uses `leo.carat.down` for the expand button and has no indent. Fix group sorting for iOS 16.4 ..< iOS 17
@iccub iccub added this to the 1.57 milestone Aug 16, 2023
@srirambv
Copy link
Contributor

Verified as part of #7618 (comment)

@Uni-verse Uni-verse mentioned this issue Nov 11, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#7765, Fix brave/brave-ios#7618: Portfolio Group B…
28b2ce7 
…y filter & Empty State (brave/brave-ios#7826)

* Support Group By Filter & Display Setting in Portfolio

* Update PortfolioStoreTests to test each filter separately, add tests for grouping by accounts and grouping by networks

* Add empty state, loading state to Portfolio Assets

* Sort order of 0 balance assets can change when tapping save filters without changing filters.

* Update `Hide Small Balances` threshold from $1 to $0.05.
Update logic so groups with no balance are only hidden when `Hide Small Balances` is enabled

* Add new `WalletDisclosureGroup` replacement for `DisclosureGroup` which uses `leo.carat.down` for the expand button and has no indent. Fix group sorting for iOS 16.4 ..< iOS 17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.57
Development

Successfully merging a pull request may close this issue.

Fix #7765, Fix #7618: Portfolio Group By filter & Empty State brave/brave-ios
3 participants
@StephenHeaps @iccub @srirambv