This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #7947, #7944, #7948, #7946: Portfolio Fixes #7950
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Hide Unowned
andShow Network Logo
toggles not resetting whenReset
tapped in NFT tab's Filters & Display SettingsReset
button in Filters & Display Settings when showing default valuesSort Order
and other pickers.This pull request...
fixes #7947
fixes #7948
fixes #7944
fixes #7946
Submitter Checklist:
NSLocalizableString()
Test Plan:
Filecoin Account groups displayed when grouping Portfolio by Accounts
Group By
toAccounts
Save Changes
Filecoin.Accounts.hidden.mp4
NFT Filters Reset button does not reset some filters
Hide Unowned
toggle to on/enabled, changeShow Network Logo
to on/enabledReset
Hide Unowned
&Show Network Logo
are reset to off/disabledNFT.Filter.Reset.mp4
Disable Reset button if there are no changes done to portfolio settings
Reset
is not disabled, tap it to reset to default filters.Reset
button is disabled.Reset
is not disabled when not showing default filter selections.Reset.Disabled.mp4
Portfolio setting dropdown text doesn't have a smooth transition when changing
Sort Assets
toA to Z
Reset
Hig...
instead ofHigh to Low
Truncated.Picker.Label.mp4
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement