Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

NFT Filters Reset button does not reset some filters #7948

Closed
StephenHeaps opened this issue Aug 24, 2023 · 1 comment · Fixed by #7950
Closed

NFT Filters Reset button does not reset some filters #7948

StephenHeaps opened this issue Aug 24, 2023 · 1 comment · Fixed by #7950
Assignees
@StephenHeaps
Labels
Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/exclude
Milestone
1.57

Comments

@StephenHeaps
Copy link
Contributor

Description:

NFT tab's Filters & Display Settings modal does not reset Network Logo or Hide Unowned when changed from default values and tapping Reset

Steps to Reproduce

  1. Open NFT tab and tap Filters & Display Settings button
  2. Change Network Logo toggle to be on/enabled
  3. Change Hide Unowned toggle to be on/enabled
  4. Tap Reset
  5. Observe toggles are not reset

Actual result:

Toggles are not reset to default values

Expected result:

Toggles are reset to default values

Reproduces how often:

Easily reproduced

Brave Version:

v1.57+

  • Can you reproduce this issue with the most recent build from TestFlight?
  • Can you reproduce this issue with the previous version of the current build from TestFlight?
  • Can you reproduce this issue with the current build from AppStore?

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@StephenHeaps StephenHeaps self-assigned this Aug 24, 2023
@StephenHeaps StephenHeaps moved this to In Progress in Web3 Aug 24, 2023
@StephenHeaps StephenHeaps mentioned this issue Aug 24, 2023
Merged
11 tasks
@StephenHeaps StephenHeaps added this to the 1.57 milestone Aug 24, 2023
@StephenHeaps StephenHeaps moved this from In Progress to In Review in Web3 Aug 24, 2023
StephenHeaps added a commit that referenced this issue Aug 24, 2023
@StephenHeaps
Fix #7947, #7944, #7948, #7946: Portfolio Fixes (#7950)
98c7464 
* Hide/Remove Filecoin accounts from Portfolio & NFT filters until they are supported.

* Fix `Network Logo` and `Hide Unowned` NFT Filters & Display Settings toggles not resetting to defaults when `Reset` tapped

* Disable `Reset` button on Filters & Display Settings when filters are showing defaults.

* Fix Filters & Display Settings Picker text truncated, janky animation when switching selection.
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Aug 24, 2023
StephenHeaps added a commit that referenced this issue Aug 24, 2023
@StephenHeaps
Fix #7947, #7944, #7948, #7946: Portfolio Fixes (#7950)
c5a8cdb 
* Hide/Remove Filecoin accounts from Portfolio & NFT filters until they are supported.

* Fix `Network Logo` and `Hide Unowned` NFT Filters & Display Settings toggles not resetting to defaults when `Reset` tapped

* Disable `Reset` button on Filters & Display Settings when filters are showing defaults.

* Fix Filters & Display Settings Picker text truncated, janky animation when switching selection.
@srirambv
Copy link
Contributor

Verification passed on iPhone 13 with iOS 16.6 running 1.57 (23.8.28.22)

  • Verified steps from issue description
  • Verified reset button resets all filters to default state in NFT filter settings
7948.MP4

arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#7947, brave/brave-ios#7944, brave/brave-ios#7948, b…
40d28b4 
…rave/brave-ios#7946: Portfolio Fixes (brave/brave-ios#7950)

* Hide/Remove Filecoin accounts from Portfolio & NFT filters until they are supported.

* Fix `Network Logo` and `Hide Unowned` NFT Filters & Display Settings toggles not resetting to defaults when `Reset` tapped

* Disable `Reset` button on Filters & Display Settings when filters are showing defaults.

* Fix Filters & Display Settings Picker text truncated, janky animation when switching selection.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.57
Development

Successfully merging a pull request may close this issue.

Fix #7947, #7944, #7948, #7946: Portfolio Fixes brave/brave-ios
2 participants
@StephenHeaps @srirambv