Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Portfolio Filters and Display Settings #7585

Closed
StephenHeaps opened this issue Jun 7, 2023 · 1 comment · Fixed by #7665
Closed

Portfolio Filters and Display Settings #7585

StephenHeaps opened this issue Jun 7, 2023 · 1 comment · Fixed by #7665
Assignees
@StephenHeaps
Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.57

Comments

@StephenHeaps
Copy link
Contributor

StephenHeaps commented Jun 7, 2023 •
edited
Loading

Description:

Add a modal that contains filters and display settings for Portfolio (ideally re-usable with NFT / Activity tabs, etc.).

Filters and Display Settings Filters and Display Settings

Group By (TBD, needs Portfolio v2 designs):

  • Accounts
  • Network
  • None

Sort Assets:

  • Price/fiat high -> low (default, current behaviour)
  • Price/fiat low -> high
  • A-Z
  • Z-A

Hide assets with <$1 value toggle.

Network Filter(s):

  • Checkmark/box beside each network, grouped by Primary/Secondary/Test networks.
  • Primary networks are shown, secondary & test networks hidden behind expandable arrow button.
  • All networks selected by default, except test networks (current behaviour).

Accounts Filter:

  • All accounts are selected by default

cc @kleantzogu @jamesmudgett @HEagle18
@StephenHeaps StephenHeaps self-assigned this Jun 7, 2023
@StephenHeaps StephenHeaps added this to Web3 Jun 7, 2023
@StephenHeaps StephenHeaps moved this to Backlog in Web3 Jun 7, 2023
@StephenHeaps StephenHeaps moved this from Backlog to In Progress in Web3 Jun 14, 2023
@StephenHeaps StephenHeaps mentioned this issue Jun 16, 2023
Closed
@StephenHeaps StephenHeaps mentioned this issue Jun 29, 2023
Merged
11 tasks
@StephenHeaps StephenHeaps mentioned this issue Jul 7, 2023
Closed
@StephenHeaps StephenHeaps added this to the 1.57 milestone Jul 13, 2023
StephenHeaps added a commit that referenced this issue Jul 17, 2023
@StephenHeaps
Fix #7585: Portfolio filters and display settings (#7665)
fecb90d 
* Create FiltersDisplaySettingsView for Portfolio filters. Allows changing sort option, hiding/showing small balances, filtering by multiple accounts, and filtering by multiple networks.

* Update Network Filter / Network Selection design for Wallet v2

* Update Account Filter / Account Selection design for Wallet v2

* Update to preserve Portfolio filter selections.

* Add A-Z sort
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Jul 17, 2023
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.57 (23.8.23.20)

  • Verified steps from #7665
  • Verified able to group assets by accounts or networks
  • Verified able to sort asset based on balance High to low/low to high
  • Verified able to sort asset in ascending (A to Z) or descending (Z to A)
  • Verified able to hide tokens with < 0.5 balance
  • Verified able to filter portfolio by specific account
  • Verified able to filter portfolio by specific network
  • Verified saved settings is retained between browser restarts
  • Encountered #7942, #7943, #7944, #7945, #7946
iPhone 7+ (iOS 15.7.8) iPhone 13 (iOS 16.6) iPad Pro (iOS 16.6)
7585-iPhone.7+.MP4
7585-iPhone.13.MP4
7585-iPad.Pro.MP4

@Uni-verse Uni-verse mentioned this issue Nov 11, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#7585: Portfolio filters and display settings (bra…
7898bcc 
…ve/brave-ios#7665)

* Create FiltersDisplaySettingsView for Portfolio filters. Allows changing sort option, hiding/showing small balances, filtering by multiple accounts, and filtering by multiple networks.

* Update Network Filter / Network Selection design for Wallet v2

* Update Account Filter / Account Selection design for Wallet v2

* Update to preserve Portfolio filter selections.

* Add A-Z sort
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.57
Development

Successfully merging a pull request may close this issue.

Fix #7585: Portfolio filters and display settings brave/brave-ios
2 participants
@StephenHeaps @srirambv