Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

NFT Filters and Display Settings #7699

Closed
StephenHeaps opened this issue Jul 7, 2023 · 1 comment · Fixed by #7750
Closed

NFT Filters and Display Settings #7699

StephenHeaps opened this issue Jul 7, 2023 · 1 comment · Fixed by #7750
Assignees
@StephenHeaps
Labels
Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.57

Comments

@StephenHeaps
Copy link
Contributor

StephenHeaps commented Jul 7, 2023 •
edited
Loading

Description:

Re-use the FiltersDisplaySettingsView from Portfolio but for the NFT tab.
Don't show the Hide Small Balances row when opened from NFT tab.
Add Network Logo / Show network logo on NFTs when opened from NFT tab.

Ref:
#7585
@StephenHeaps StephenHeaps self-assigned this Jul 7, 2023
@StephenHeaps StephenHeaps added this to Web3 Jul 7, 2023
@StephenHeaps StephenHeaps moved this to Backlog in Web3 Jul 7, 2023
@StephenHeaps StephenHeaps mentioned this issue Jul 7, 2023
Merged
11 tasks
@StephenHeaps StephenHeaps moved this from Backlog to In Progress in Web3 Jul 12, 2023
@StephenHeaps StephenHeaps mentioned this issue Jul 19, 2023
Merged
11 tasks
StephenHeaps added a commit that referenced this issue Jul 21, 2023
@StephenHeaps
Fix #7699: NFT filters and display settings (#7750)
f4fb04a 
* Integrate Filters and Display Settings into NFT tab. Add show/hide network logo on NFT odisplay setting.

* Add 'Hide Unowned' display setting for NFTs only.

* Resolve unit tests, add unit tests for NFT filters to NFTStoreTests.

* Add initializer with default values for Filters.
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Jul 21, 2023
@iccub iccub added this to the 1.57 milestone Jul 28, 2023
@srirambv
Copy link
Contributor

Verification passed on iPhone 13 with iOS 16.6 running 1.57 (23.8.24.22)

  • Verified steps from #7750
  • Verified able to filter NFTs by network
  • Verified able to filter NFTs by account
  • Verified toggling Network Logo, shows/hides the logo on NFT
  • Verified toggling Hide Unowned, shows/hides the NFTs based on filtered accounts
  • Verified filter settings set in NFT filters are carried over to Portfolio settings as well
  • Encountered #7963
7699.MP4

@Uni-verse Uni-verse mentioned this issue Nov 11, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#7699: NFT filters and display settings (brave/bra…
c8ebd06 
…ve-ios#7750)

* Integrate Filters and Display Settings into NFT tab. Add show/hide network logo on NFT odisplay setting.

* Add 'Hide Unowned' display setting for NFTs only.

* Resolve unit tests, add unit tests for NFT filters to NFTStoreTests.

* Add initializer with default values for Filters.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.57
Development

Successfully merging a pull request may close this issue.

Fix #7699: NFT filters and display settings brave/brave-ios
3 participants
@StephenHeaps @iccub @srirambv