Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Filtering NFTs by a specific network and selecting an account from a different network shouldn't show anything #7963

Closed
srirambv opened this issue Aug 25, 2023 · 1 comment

Comments

@srirambv
Copy link
Contributor

Description:

Filtering NFTs by a specific network and selecting an account from a different network shouldn't show anything

Steps to Reproduce

  1. Restore wallet that has NFTs from different network
  2. Select Solana account from account filter
  3. Select Ethereum Network from network filter
  4. Save and close settings
  5. NFTs from Ethereum account is shown when account selected is for Solana

Actual result:

Filtering NFTs from network and account always shown NFTs from filtered network

Expected result:

Filtering NFTs by a specific network and selecting an account from a different network shouldn't show anything

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easy

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? NA
  • Can you reproduce this issue with the current build from AppStore? NA

Device details:

All

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information

cc: @nuo-xu @StephenHeaps

@StephenHeaps
Copy link
Contributor

StephenHeaps commented Aug 25, 2023

This is expected behaviour because Hide Unowned is not enabled. On the NFT tab, the account filters will only hide an NFT when Hide Unowned is checked. The intention of this toggle/behaviour is to allow users to add NFTs that they do not own.

On Portfolio, the account filters do not hide assets. They exclude the de-selected accounts from the displayed balance.
On NFT tab, we do not display balance so by selecting/de-selecting accounts has no effect unless we are also hiding unowned balances.

I've opened #7966 to address slow balance fetch for NFTs when Hide Unowned is enabled.

@StephenHeaps StephenHeaps closed this as not planned Won't fix, can't repro, duplicate, stale Aug 25, 2023
@github-project-automation github-project-automation bot moved this to Done in Web3 Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

2 participants