Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Allow Multiple Selection for Network Filters #7607

Closed
StephenHeaps opened this issue Jun 16, 2023 · 1 comment · Fixed by #7617
Closed

Allow Multiple Selection for Network Filters #7607

StephenHeaps opened this issue Jun 16, 2023 · 1 comment · Fixed by #7617
Assignees
@StephenHeaps
Labels
Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.56

Comments

@StephenHeaps
Copy link
Contributor

Description:

Update the existing network filter view to allow multiple networks to be selected for filtering (removing the All Networks option. This will later be integrated with #7585 (pushed as a detail view).
@StephenHeaps StephenHeaps self-assigned this Jun 16, 2023
This was referenced Jun 19, 2023
Merged
Closed
StephenHeaps added a commit that referenced this issue Jun 22, 2023
@StephenHeaps
Fix #7607: Select Multiple Networks in Network Filter Views (#7617)
9b8a11f 
* Add support for selecting multiple networks in NetworkFilterView.

* Move Test Networks to their own section instead of a pushed detail view.

* Add select all button in toolbar, localize.

* Improve loading performance in Asset Search, add initializer that doesn't require NetworkStore.

* Update network filters when a custom chain is added or removed.
@iccub iccub added this to the 1.53 milestone Jun 28, 2023
@srirambv
Copy link
Contributor

srirambv commented Aug 1, 2023

Verification passed on iPhone 13 with iOS 16.5 running 1.56 (23.7.31.17)

  • Verified steps from #7617
  • Verified network filter works as expected on portfolio tab
  • Verified Test networks are not enabled on Portfolio, NFT tabs when test networks are enabled
  • Verified Test networks are enabled by default on Activity, Edit visible assets and Send token tabs
  • Verified show/hide button enables/disables test networks when enabled
7607.MP4

@Uni-verse Uni-verse mentioned this issue Nov 10, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#7607: Select Multiple Networks in Network Filter …
de9f518 
…Views (brave/brave-ios#7617)

* Add support for selecting multiple networks in NetworkFilterView.

* Move Test Networks to their own section instead of a pushed detail view.

* Add select all button in toolbar, localize.

* Improve loading performance in Asset Search, add initializer that doesn't require NetworkStore.

* Update network filters when a custom chain is added or removed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.56
Development

Successfully merging a pull request may close this issue.

Fix #7607: Select Multiple Networks in Network Filter Views brave/brave-ios
3 participants
@StephenHeaps @iccub @srirambv