Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable history sync datatype to fallback to typed urls datatype #20071

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Sep 8, 2023

Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/874f434296a6d02c9a2adcc5c664aa7915bf8681

Enable SyncEnableHistoryDataType by default

Bug: 1318028
Change-Id: Iee7539bb25c41279f333558934a3438e51487a71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4055561

Resolves brave/brave-browser#32857

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@AlexeyBarabash AlexeyBarabash requested a review from a team as a code owner September 8, 2023 15:03
@AlexeyBarabash AlexeyBarabash self-assigned this Sep 8, 2023
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Sep 8, 2023
namespace syncer {

OVERRIDE_FEATURE_DEFAULT_STATES({{
{kSyncEnableHistoryDataType, base::FEATURE_DISABLED_BY_DEFAULT},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be just a workaround right?
I think we need to investigate in HistoryDataType because I can foresee typed url data type will go away sooner or later. Please open an issue for that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this is a workaround to fix CR117 regression.

Proper solution is on the way, some investigations were done at #17216.

Created issue: brave/brave-browser#32876

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 using version:

Brave	1.60.11 Chromium: 117.0.5938.48 (Official Build) canary (32-bit) 
Revision	31e5a6923b9af06a63afc70bd2907933cfd26df7
OS	Android 13; Build/TP1A.220624.014; 33; REL
Example Example Example
Screenshot 2023-09-11 at 2 58 49 PM Screenshot 2023-09-11 at 3 33 14 PM Screenshot 2023-09-11 at 3 33 53 PM

kjozwiak pushed a commit that referenced this pull request Sep 11, 2023
kjozwiak pushed a commit that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) feature/sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

History is not synced on fresh profile [C117]
3 participants