-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable history sync datatype to fallback to typed urls datatype #20071
Conversation
Fixes brave/brave-browser#32857 Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/874f434296a6d02c9a2adcc5c664aa7915bf8681 Enable SyncEnableHistoryDataType by default Bug: 1318028 Change-Id: Iee7539bb25c41279f333558934a3438e51487a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4055561
namespace syncer { | ||
|
||
OVERRIDE_FEATURE_DEFAULT_STATES({{ | ||
{kSyncEnableHistoryDataType, base::FEATURE_DISABLED_BY_DEFAULT}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be just a workaround right?
I think we need to investigate in HistoryDataType because I can foresee typed url data type will go away sooner or later. Please open an issue for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes this is a workaround to fix CR117 regression.
Proper solution is on the way, some investigations were done at #17216.
Created issue: brave/brave-browser#32876
Verified on
|
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/874f434296a6d02c9a2adcc5c664aa7915bf8681
Enable SyncEnableHistoryDataType by default
Bug: 1318028
Change-Id: Iee7539bb25c41279f333558934a3438e51487a71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4055561
Resolves brave/brave-browser#32857
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: