Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History is not synced on fresh profile [C117] #32857

Closed
Uni-verse opened this issue Sep 7, 2023 · 4 comments · Fixed by brave/brave-core#20071
Closed

History is not synced on fresh profile [C117] #32857

Uni-verse opened this issue Sep 7, 2023 · 4 comments · Fixed by brave/brave-core#20071

Comments

@Uni-verse
Copy link
Contributor

Description

History is not synced on fresh profile [Android]

Steps to reproduce

  1. Create sync chain on MacOS client existing profile
  2. Connect to sync chain on fresh install
  3. Enable history syncing
  4. Open History page

Actual result

Screenshot 2023-09-07 at 4 32 05 PM

Expected result

History should show up

Issue reproduces how often

Always (fresh profile)

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? No
  • Can you reproduce this issue with the current Play Store Beta version? TBD
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung GS 21
  • Android version: 13

Brave version

1.60.2 Chromium 117.0.5938.35

@stephendonner
Copy link

stephendonner commented Sep 8, 2023

This also affects desktop as well (1.60.1-1.60.6):

Brave | 1.60.6 Chromium: 117.0.5938.48 (Official Build) nightly (x86_64)
-- | --
Revision | 3729c99b569a7aab570e3f55471c699556e539f9
OS | macOS Version 14.0 (Build 23A5337a)

I can reproduce the issue as follows:

  1. set up a Sync chain on Android 8, build 1.60.1
  2. typed the code words/phrase into desktop 1.57.62 (macOS-x64)
  3. chose to sync all data types
  4. typed and loaded a bunch of URLs on desktop
  5. waited
  6. opened brave://history

Confirmed NO typed entries are synced from desktop to Android

I tried the combinations of starting a Sync chain from either/both desktop and mobile, and connected those to nightly and release builds.

  • release <-> release (android/desktop - and vice-versa) ✅
  • nightly <-> release (android/desktop - and vice-versa) ❌
  • nightly <-> nightly (android/desktop - and vice-versa) ❌

The only time typed URLs are synced in brave://history between mobile and desktop clients are when both are on release, per my testing (likely works on beta, but I haven't yet checked there.)

Note: this only affects typed URLs; pages visited in tabs are synced correctly from mobile to desktop via Synced tabs from other devices.

@kjozwiak
Copy link
Member

The above requires 1.58.121 or higher for 1.58.x verification 👍

@Uni-verse
Copy link
Contributor Author

Verified on Samsung Galaxy S21 using version:

Brave	1.58.121 Chromium: 117.0.5938.48 (Official Build) (32-bit) 
Revision	d80a8110b88df6ae5073d8420fada4168542786f
OS	Android 13; Build/TP1A.220624.014; 33; REL
Example Example
Screenshot 2023-09-12 at 12 28 57 PM Screenshot 2023-09-12 at 12 29 31 PM

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 12, 2023
@stephendonner
Copy link

stephendonner commented Sep 12, 2023

Verification PASSED using

Brave | 1.58.121 Chromium: 117.0.5938.48 (Official Build) (x86_64)
-- | --
Revision | d80a8110b88df6ae5073d8420fada4168542786f
OS | macOS Version 11.7.10 (Build 20G1427)

Steps:

  1. installed 1.58.121
  2. launched Brave
  3. clicked on the hamburger menu icon
  4. clicked More Tools
  5. clicked Sync
  6. clicked Start a new Sync Chain
  7. clicked Phone/Tablet
  8. scanned QR code with latest Android release (1.57.62)
  9. tapped and loaded a series of URLs (alphabetical) on Android
  10. waited for a couple minutes
  11. opened brave://history on Android
  12. opened brave://history on desktop (macOS)
  13. compared history entries

Confirmed all tapped (typed) URL entries from A-H were synced from mobile -> desktop

Android

example example example example example
Screenshot_20230907-153323 Screenshot_20230912-153229 Screenshot_20230912-153309 Screenshot_20230912-153315 Screenshot_20230912-153532

desktop (macOS)

example example example
Screen Shot 2023-09-12 at 3 32 54 PM Screen Shot 2023-09-12 at 3 33 05 PM Screen Shot 2023-09-12 at 3 37 43 PM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 12, 2023
@rebron rebron moved this to Completed in Sync - All platforms Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment