Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable history sync datatype to fallback to typed urls datatype (uplift to 1.59.x) #20095

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Disable history sync datatype to fallback to typed urls datatype (uplift to 1.59.x) #20095

merged 1 commit into from
Sep 11, 2023

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Sep 11, 2023 •
edited by kjozwiak
Loading

Uplift of #20071
Resolves brave/brave-browser#32857

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner September 11, 2023 13:36
@brave-builds brave-builds self-assigned this Sep 11, 2023
@brave-builds brave-builds added this to the 1.59.x - Beta milestone Sep 11, 2023
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Sep 11, 2023
kjozwiak
kjozwiak approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.59.x approved 👍 QA has verified the PR on Nightly as per #20071 (comment).

@kjozwiak kjozwiak merged commit 1cd2cd4 into 1.59.x Sep 11, 2023
@kjozwiak kjozwiak deleted the pr20071_fix_32857_1.59.x branch September 11, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Milestone
1.59.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@brave-builds @kjozwiak