Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] [Sync] Enable History sync data type #33839

Closed
soner-yuksel opened this issue Oct 23, 2023 · 0 comments · Fixed by brave/brave-core#20642
Closed

[iOS] [Sync] Enable History sync data type #33839

soner-yuksel opened this issue Oct 23, 2023 · 0 comments · Fixed by brave/brave-core#20642
Assignees
Labels
feature/sync OS/iOS Fixes related to iOS browser functionality QA/No release-notes/exclude

Comments

@soner-yuksel
Copy link

Description

Since CR117 Chromium uses history datatype instead of typed urls.

Implementation Details

To fix #32857 regression, was done brave/brave-core#20071.
And after that History Data Type is added properly with brave/brave-core#20329

Additional information

To support this functionality fully on iOS, some changed should be done on iOS API. This will also allow all objects in History to be synced not just typed_urls.

To allow all history sync, typed_url selection logic should be changed on iOS side brave/brave-ios#8305
The All History Sync logic change and History Sync Sanity check can be done with this ticket which should be in 1.60 iOS release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/sync OS/iOS Fixes related to iOS browser functionality QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants