Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable history sync datatype to fallback to typed urls datatype #20071

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Disable history sync datatype to fallback to typed urls datatype #20071

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions chromium_src/components/sync/base/features.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
/* Copyright (c) 2023 The Brave Authors. All rights reserved.
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at https://mozilla.org/MPL/2.0/. */

#include "src/components/sync/base/features.cc"

#include "base/feature_override.h"

namespace syncer {

OVERRIDE_FEATURE_DEFAULT_STATES({{
{kSyncEnableHistoryDataType, base::FEATURE_DISABLED_BY_DEFAULT},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be just a workaround right?
I think we need to investigate in HistoryDataType because I can foresee typed url data type will go away sooner or later. Please open an issue for that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this is a workaround to fix CR117 regression.

Proper solution is on the way, some investigations were done at #17216.

Created issue: brave/brave-browser#32876

}});

} // namespace syncer