Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulled l10n for 1.37.x release (Chromium 100). Part II. (uplift to 1.37.x) #12970

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#22185
Fixes brave/brave-browser#21808
Fixes brave/brave-browser#21980
Fixes brave/brave-browser#22104

Uplift from #12957

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Pulled l10n for 1.37.x release (Chromium 100). Part II.
@mkarolin mkarolin requested a review from a team April 11, 2022 19:11
@mkarolin mkarolin requested a review from a team as a code owner April 11, 2022 19:11
@mkarolin mkarolin requested review from bsclifton and szilardszaloki and removed request for a team April 11, 2022 19:11
@mkarolin mkarolin self-assigned this Apr 11, 2022
@kjozwiak kjozwiak added this to the 1.37.x - Release #6 milestone Apr 12, 2022
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.37.x approved 👍

@kjozwiak kjozwiak merged commit befead1 into 1.37.x Apr 12, 2022
@kjozwiak kjozwiak deleted the maxk-1.37.x-l10n-II-1.37.x branch April 12, 2022 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants