Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update l10n for 1.37.x (Chromium 100) - Part II. #22185

Closed
mkarolin opened this issue Apr 8, 2022 · 4 comments · Fixed by brave/brave-core#12957
Closed

Update l10n for 1.37.x (Chromium 100) - Part II. #22185

mkarolin opened this issue Apr 8, 2022 · 4 comments · Fixed by brave/brave-core#12957

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Apr 8, 2022

Download the latest l10n from Transifex.

Test plan:

https://github.com/orgs/brave/teams/legacy_qa should run through a few locals just to make sure that nothing obvious has regressed. Shouldn't spend too much time on this though.

@kjozwiak
Copy link
Member

Above requires 1.37.114 or higher for 1.37.x verification.

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 13, 2022
@LaurenWags
Copy link
Member

LaurenWags commented Apr 13, 2022

Verified with

Brave | 1.37.114 Chromium: 100.0.4896.88 (Official Build) (x86_64)
-- | --
Revision | 4450653bfa91182e85723d8f1dee64dd6ce40ed4-refs/branch-heads/4896@{#1086}
OS | macOS Version 12.3.1 (Build 21E258)

Spot checked the following areas for translations:

  • brave://welcome
  • new tab page (including default widgets - Rewards and Talk, Dashboard config settings)
  • brave://rewards
  • brave://settings
  • brave://wallet

Completed spot checks for German, French, Spanish

Also, verified the following issues from the PR:
#21808 (comment)
#21980 (comment)
#22104 (comment)

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 13, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 13, 2022

Verification Complete for Android ARM using 1.37.114, Chromium 100.0.4869.88 on Samsung Galaxy S21 running Android 12

  • Verified translations using system language as well as switching app language

Translations Test Plan:

  • Settings
  • Rewards
  • Shields
  • Wallet
  • Context Menus
  • Sync
  • Onboarding/Tip items
  • News

Languages: French, Russian, German

Issues:

Menu - Notifications (French) Notifications (French) Notifications Categories (French) Default Engine News Categories Address Error Msg URL Context Menu (Russian) Context Menu (Russian)
Screen Shot 2022-04-13 at 1 28 06 PM Screen Shot 2022-04-13 at 1 28 18 PM Screen Shot 2022-04-13 at 1 28 32 PM Screen Shot 2022-04-13 at 1 31 04 PM Screen Shot 2022-04-13 at 1 34 39 PM Screen Shot 2022-04-13 at 1 37 23 PM Screen Shot 2022-04-13 at 2 34 30 PM Screen Shot 2022-04-13 at 2 40 05 PM

@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 13, 2022

Verification Complete for Android Tab using 1.37.114, Chromium 100.0.4869.88 on Samsung Galaxy Tab S7 running Android 12

Translations Test Plan:

  • Onboarding items
  • Rewards
  • Shields
  • Wallet
  • Settings

Languages: Spanish, German

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment