Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Brave Wallet icon on toolbar is not translated #21808

Closed
Tonev opened this issue Mar 22, 2022 · 4 comments · Fixed by brave/brave-core#12957
Closed

Hide Brave Wallet icon on toolbar is not translated #21808

Tonev opened this issue Mar 22, 2022 · 4 comments · Fixed by brave/brave-core#12957
Labels
l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/exclude

Comments

@Tonev
Copy link
Contributor

Tonev commented Mar 22, 2022

Description

Found out the option that allows users to hide the wallet icon via a right-click is not translated in other languages. I quickly tested Bulgarian and Polish, it's quite possible that the string is not translated in more languages as well.

The feature is currently available in Brave Nightly and Brave Beta.

Steps to Reproduce

  1. Install Brave Nightly or Brave Beta.
  2. Set the browser to be displayed in a language different than English, you could try in Bulgarian or Polish, for example.
  3. Make sure Show Brave Wallet icon on toolbar is enabled via brave://settings/wallet.
  4. Right-click on the Brave Wallet icon on the toolbar.

Actual result:

image

Expected result:

Hide Brave Wallet icon on toolbar should be translated.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.38.60 Chromium: 100.0.4896.46 (Official Build) nightly (64-bit)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS Windows 7 Service Pack 1 (Build 7601)
Brave 1.37.97 Chromium: 99.0.4844.74 (Official Build) beta (64-bit)
Revision fee9a47e86e981802390cb0d41c5ed7ea93c4f6f-refs/branch-heads/4844@{#1060}
OS Windows 7 Service Pack 1 (Build 7601)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Miscellaneous Information:

CC: @mkarolin

P.S If you take a closer look at the screenshot, you'll notice that the new Privacy and security rename that CR100 brought us is also not translated. I'll wait until you merge an updated CR100 l10n package, and will open a ticket for it if necessary 👍

@rebron rebron added l10n priority/P2 A bad problem. We might uplift this to the next planned release. labels Mar 24, 2022
@rebron rebron added this to Web3 Mar 24, 2022
@Tonev
Copy link
Contributor Author

Tonev commented Mar 30, 2022

#21963 didn't fix the issue. I checked Bulgarian and Polish once again.

Brave 1.39.18 Chromium: 100.0.4896.60 (Official Build) nightly (64-bit)
Revision 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS Windows 7 Service Pack 1 (Build 7601)

@mkarolin
Copy link
Contributor

Thanks @Tonev! Unfortunately, the translations for those two languages aren't available yet ☹️. They should be coming in a follow up l10n round.

@kjozwiak
Copy link
Member

Above requires 1.37.114 or higher for 1.37.x verification.

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 13, 2022
@LaurenWags
Copy link
Member

Verified using

Brave | 1.37.114 Chromium: 100.0.4896.88 (Официално издание) (x86_64)
-- | --
Ревизия | 4450653bfa91182e85723d8f1dee64dd6ce40ed4-refs/branch-heads/4896@{#1086}
ОС | macOS Version 12.3.1 (Build 21E258)

Confirmed translation in a few languages

Spanish Polish Bulgarian
Spanish Polish Bulgarian

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/exclude
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants