Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"A free token grant is available" line item appears in Brave Rewards summary (in Spanish) #22104

Closed
Miyayes opened this issue Apr 5, 2022 · 3 comments · Fixed by brave/brave-core#12957
Closed

"A free token grant is available" line item appears in Brave Rewards summary (in Spanish) #22104

Miyayes opened this issue Apr 5, 2022 · 3 comments · Fixed by brave/brave-core#12957
Assignees
@mkarolin
Labels
bug feature/rewards l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/exclude rewards-2.0
Milestone
1.37.x - Release #6

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Apr 5, 2022

Description

"A free token grant is available" string and line item shouldn't exist.

image
@Miyayes Miyayes added the l10n label Apr 5, 2022
@szilardszaloki
Copy link
Contributor

szilardszaloki commented Apr 6, 2022 •
edited
Loading

This should say Monthly Tips in Spanish.

@Miyayes Miyayes added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 6, 2022
@mkarolin mkarolin mentioned this issue Apr 8, 2022
Merged
25 tasks
This was referenced Apr 11, 2022
Merged
Merged
@kjozwiak kjozwiak added this to the 1.37.x - Release #6 milestone Apr 12, 2022
@kjozwiak
Copy link
Member

Above requires 1.37.114 or higher for 1.37.x verification.

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 13, 2022
@LaurenWags
Copy link
Member

Verified using

Brave | 1.37.114 Chromium: 100.0.4896.88 (Build oficial) (x86_64)
-- | --
Revisión | 4450653bfa91182e85723d8f1dee64dd6ce40ed4-refs/branch-heads/4896@{#1086}
Sistema operativo | macOS Versión 12.3.1 (Compilación 21E258)

Reproduced the issue using 1.37.113. Confirmed translation updated with 1.37.114.

1.37.113 1.37.114
1 37 113 1 37 114

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 13, 2022
@LaurenWags LaurenWags mentioned this issue Apr 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
bug feature/rewards l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/exclude rewards-2.0
Projects
None yet
Milestone
1.37.x - Release #6
Development

Successfully merging a pull request may close this issue.

Pulled l10n for 1.37.x release (Chromium 100). Part II. brave/brave-core
5 participants
@kjozwiak @szilardszaloki @Miyayes @LaurenWags @mkarolin