Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pocket extension crashes #991

Closed
rebron opened this issue Sep 6, 2018 · 4 comments · Fixed by brave/brave-core#421
Closed

Pocket extension crashes #991

rebron opened this issue Sep 6, 2018 · 4 comments · Fixed by brave/brave-core#421

Comments

@rebron
Copy link
Collaborator

rebron commented Sep 6, 2018

Description

Pocket Extension crashes when trying to invoke (by clicking Pocket icon) Page Saved! function.

Steps to Reproduce

  1. Install Pocket extension: https://chrome.google.com/webstore/detail/save-to-pocket/niloccemoadcdkdjlinkgdfekeahmflj?hl=en
  2. Sign in.
  3. Go to any page and select Pocket icon and Pocket Extension will crash.

Actual result:

Pocket Extension crashes and requires a reload. Reloading Pocket will keep you in the same crash loop.

On restart of the browser, Pocket icon will be loaded and reappear and may function to 'save to pocket' on 1-2 pages. 3rd page, resulted in a crash.

Expected result:

Selecting Pocket extension will 'save page to pocket' and display a drop down menu with notification of Page Saved! plus additional related content with the menu disappearing after a few seconds.

Reproduces how often:

Every time.

Brave version (about:brave info)

Version 0.55.1 Chromium: 70.0.3528.4 (Official Build) dev (64-bit)

Additional Information

Issue reproduced on Win x64 and MacOS Mojave 10.14 beta

@rebron rebron added this to the 1.0 milestone Sep 6, 2018
@bbondy bbondy modified the milestones: 1.0, Releasable builds 0.55.x Sep 6, 2018
@rebron rebron added the bug label Sep 6, 2018
@stshank
Copy link

stshank commented Sep 6, 2018

I experienced this too on MacOS Mojave beta.

@srirambv
Copy link
Contributor

srirambv commented Sep 7, 2018

Dupe of #685? (for a different extension)

@rebron
Copy link
Collaborator Author

rebron commented Sep 7, 2018

Possible but Pocket extension is crashing and becomes disabled, browser isn't crashing like in #685.

@kjozwiak
Copy link
Member

kjozwiak commented Sep 20, 2018

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Verification Passed on:

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants