Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing Google Translate extension breaks Brave Translate #26152

Open
stephendonner opened this issue Oct 20, 2022 · 4 comments
Open

Installing Google Translate extension breaks Brave Translate #26152

stephendonner opened this issue Oct 20, 2022 · 4 comments
Labels
brave-translate bug feature/translate OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@stephendonner
Copy link

Description

Installing Google Translate extension breaks Brave Translate

Steps to Reproduce

  1. install 1.47.2
  2. launch Brave
  3. load mail.ru
  4. click on the Translate this page icon in the URL bar, and select English
  5. confirm translation works
  6. load https://chrome.google.com/webstore/detail/google-translate/aapbdbdomjkkjkaonfhkkikfgjllcleb?hl=en
  7. click on Add to Brave
  8. click on Add extension
  9. reload mail.ru
  10. click on the Translate this page icon in the URL bar

Actual result:

Nothing happens

Screen Shot 2022-10-20 at 10 36 00 AM

Expected result:

Maybe the Google Translate extension should still work?

Screen Shot 2022-10-20 at 10 28 40 AM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.47.2 Chromium: 107.0.5304.36 (Official Build) nightly (x86_64)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS macOS Version 11.7 (Build 20G817)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @MadhaviSeelam @GeetaSarvadnya @rebron

@GeetaSarvadnya
Copy link

Reproduced in Windows 10 x64 - 1.45.108

image

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 21, 2022
@rebron
Copy link
Collaborator

rebron commented Oct 21, 2022

cc: @atuchin-m

@atuchin-m
Copy link
Contributor

@stephendonner I can't reproduced this in 1.47.6
Also the code to check the extension is removed in #24715
But it's an expected behavior before the fix.
Could you please double check the version?

@stephendonner
Copy link
Author

stephendonner commented Oct 26, 2022

Sorry for the delay; I'm unable to reproduce as written, using

Brave 1.47.33 Chromium: 107.0.5304.91 (Official Build) nightly (x86_64)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS macOS Version 11.7.1 (Build 20G918)

Built-in Brave Translate and added Google Translate; confirmed both are working.

Screen Shot 2022-10-31 at 1 50 15 PM

@GeetaSarvadnya @MadhaviSeelam mind also checking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brave-translate bug feature/translate OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Development

No branches or pull requests

4 participants