Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common Sense Media's favicon is stretched, aspect-ratio wise #26368

Closed
stephendonner opened this issue Oct 28, 2022 · 3 comments · Fixed by brave/brave-core#15713
Closed

Common Sense Media's favicon is stretched, aspect-ratio wise #26368

stephendonner opened this issue Oct 28, 2022 · 3 comments · Fixed by brave/brave-core#15713

Comments

@stephendonner
Copy link

Description

Common Sense Media's favicon is stretched, aspect-ratio wise

Steps to Reproduce

  1. install 1.46.81
  2. launch Brave
  3. set brave://flags/#brave-news-v2 to Enabled
  4. set brave://flags/#brave-news-subscribe-button to Enabled
  5. click Relaunch
  6. open a new-tab page
  7. scroll down
  8. click on Show Brave News
  9. click on Customize
  10. type common under Discover
  11. click on Follow
  12. compare the favicon to the larger one in Sources

Actual result:

Screen Shot 2022-10-28 at 10 58 17 AM

Expected result:

Should be normal proportions/aspect ratios.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (x86_64)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS macOS Version 11.7.1 (Build 20G918)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

/cc @fallaciousreasoning @rebron

@stephendonner
Copy link
Author

Also affects the American Psychological Association's icon

Screen Shot 2022-10-28 at 11 12 17 AM

@kjozwiak
Copy link
Member

kjozwiak commented Nov 3, 2022

The above requires 1.46.90 or higher for 1.46.x verification 👍

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.46.91 Chromium: 107.0.5304.91 (Official Build) dev (x86_64)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS macOS Version 11.7.1 (Build 20G918)

Steps:

  1. install 1.46.91
  2. launch Brave
  3. set brave://flags/#brave-news-v2 to Enabled
  4. set brave://flags/#brave-news-subscribe-button to Enabled
  5. click Relaunch
  6. open a new-tab page
  7. scroll down
  8. click on Show Brave News
  9. click on Customize
  10. type common under Discover
  11. click on Follow
  12. compare the favicon to the larger one in Sources

Confirmed both the Common Sense and American Psychological Association favicons/icons are correctly-sized 👍

Common Sense APA
Screen Shot 2022-11-03 at 8 36 38 AM Screen Shot 2022-11-03 at 8 36 47 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment