Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave News Sources Migration #24550

Closed
fallaciousreasoning opened this issue Aug 9, 2022 · 5 comments · Fixed by brave/brave-core#14565
Closed

Brave News Sources Migration #24550

fallaciousreasoning opened this issue Aug 9, 2022 · 5 comments · Fixed by brave/brave-core#14565

Comments

@fallaciousreasoning
Copy link

fallaciousreasoning commented Aug 9, 2022

One of the issues we have with the Brave News V2 work is that we need to ensure that the user doesn't lose access to any of their subscriptions when we switch over to the new list of feeds (which doesn't contain all of the sources in the old feed list).

Our proposed solution here is to add the feeds which have disappeared, that the user was subscribed to to the user's direct feeds. This means, that for a while at least, we'll need to keep the old sources.json files available.

@fallaciousreasoning fallaciousreasoning added OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 9, 2022
@fallaciousreasoning
Copy link
Author

@petemill @aurangzaib048 for your thoughts

@stephendonner
Copy link

Verified PASSED using

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (x86_64)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS macOS Version 11.7.1 (Build 20G918)

Steps:

  1. installed 1.46.81
  2. launched Brave
  3. opened a new-tab page
  4. scrolled down
  5. clicked on Show Brave News
  6. clicked on Customize
  7. clicked on Brave News
  8. clicked on All Sources
  9. toggled Hollywood Life to Enabled
  10. opened brave://flags/
  11. set brave://flags/#brave-news-v2 to Enabled
  12. clicked on Relaunch
  13. confirmed I was Following the Hollywood Life feed source

(But could not confirm it via Brave News feed. Will continue investigating and file, if needed.)

example example example
Screen Shot 2022-10-27 at 4 14 01 PM Screen Shot 2022-10-27 at 4 14 04 PM Screen Shot 2022-10-27 at 4 16 01 PM

@MadhaviSeelam
Copy link

MadhaviSeelam commented Oct 28, 2022

Verification PASSED using

Brave | 1.46.83 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
-- | --
Revision | a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS | Windows 11 Version 21H2 (Build 22000.1098)

Steps:

  1. Install 1.46.83
  2. opened a new-tab page
  3. scrolled down
  4. clicked on Show Brave News
  5. clicked on Customize
  6. clicked on Brave News
  7. clicked on All Sources
  8. toggled Hollywood Life to Enabled
  9. opened brave://flags/
  10. set brave://flags/#brave-news-v2 to Enabled
  11. clicked on Relaunch
  12. click to open NTP
  13. confirmed Brave News is still enabled
  14. click Customize
  15. click Brave News
  16. new Brave News UI displayed

Confirmed Hollywood Life feed source displayed on the left panel of the Following section

step 4 step 8 step10 result
image image image image

@srirambv
Copy link
Contributor

srirambv commented Nov 3, 2022

Verification passed on Oppo Reno 5 with Android 12 running 1.46.87 x64 beta build

  • Verified steps from brave/brave-core#14565
  • Verified manually enabled source is listed under Your sources post migration
24550.mp4

@btlechowski
Copy link

Verification passed on

Brave 1.46.117 Chromium: 107.0.5304.110 (Official Build) beta (64-bit)
Revision 2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202}
OS Ubuntu 18.04 LTS

Steps:

  1. Install 1.45.x
  2. opened a new-tab page
  3. scrolled down
  4. clicked on Show Brave News
  5. clicked on Customize
  6. clicked on Brave News
  7. clicked on All Sources
  8. toggled Hollywood Life to Enabled
  9. install 1.46.x
  10. clicked on Relaunch
  11. click to open NTP
  12. confirmed Brave News is still enabled
  13. click Customize
  14. click Brave News
  15. new Brave News UI displayed

Confirmed Hollywood Life feed source displayed on the left panel of the Following section

1.45.x
image

1.46.x
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants