-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update trgt to 1.2.0 #51017
Update trgt to 1.2.0 #51017
Conversation
📝 WalkthroughWalkthroughThe pull request updates the package "trgt" by incrementing its version from "1.1.0" to "1.2.0" and modifying the SHA256 checksum for integrity verification. These changes reflect a new release of the package, ensuring that the versioning and checksum are current and accurate. Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/trgt/meta.yaml (1)
Line range hint
1-43
: Consider making the package noarch.The recipe is currently set to
noarch: false
and skips building for non-linux64 platforms. However, since the package is a pre-built binary for linux64, it might be more appropriate to make it anoarch
package with aconstrains
section.Consider the following changes:
build: number: 0 - skip: true # [not linux64] - noarch: false + noarch: generic script: - mkdir -p ${PREFIX}/bin - cp trgt ${PREFIX}/bin/ - chmod +x ${PREFIX}/bin/trgt run_exports: - {{ pin_subpackage('trgt', max_pin="x") }} +requirements: + run: + - linux-64 * + test: commands: - trgt --versionThis change would make the package
noarch
while still ensuring it's only installed on linux-64 systems. Please consult with other maintainers to decide if this change is appropriate for your use case.🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/trgt/meta.yaml (1 hunks)
🔇 Additional comments (2)
recipes/trgt/meta.yaml (2)
3-3
: Checksum update looks good, but verification is recommended.The SHA256 checksum has been updated, which is necessary for the new version. However, it's crucial to verify its correctness.
To ensure the integrity and security of the package, please run the following verification:
If the script output matches the checksum, it confirms the integrity of the package.
2-2
: Version update looks good.The version has been correctly updated to 1.2.0, which aligns with the PR objectives.
Let's verify if this version update is consistent throughout the file:
@BiocondaBot please add label |
Update
trgt
: 1.1.0 → 1.2.0recipes/trgt
(click to view/edit other files)@PacificBiosciences
This pull request was automatically generated (see docs).