Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tttrlib to 0.25.1 #52127

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Update tttrlib to 0.25.1 #52127

merged 4 commits into from
Nov 15, 2024

Conversation

BiocondaBot
Copy link
Collaborator

Update tttrlib: 0.25.00.25.1

install with bioconda Conda

Info Link or Description
Recipe recipes/tttrlib (click to view/edit other files)
Summary A file format agnostic library for time-resolved imaging and spectroscopic data.
Home https://github.com/fluorescence-tools/tttrlib
Releases https://github.com/Fluorescence-Tools/tttrlib/tags
Recipe Maintainer(s) @tpeulen, @khemmen
Author @Fluorescence-Tools

This pull request was automatically generated (see docs).

@BiocondaBot BiocondaBot added autobump Automatic Version Update new version labels Nov 15, 2024
Copy link
Contributor

coderabbitai bot commented Nov 15, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

This pull request introduces an update to the meta.yaml file for the tttrlib package. The primary change is the increment of the version number from 0.25.0 to 0.25.1. Alongside this version update, the SHA256 checksum for the source tarball has also been modified, changing from e15604ef063257cd87d3bdf266c1d5a448189508f51cdc4156a93cb2b46fe807 to a224214e50d7a202ef1d264c64641ab0b26f29bf756a96659489847953b698a6. Additionally, the skip directive under the build section has been removed. New entries for additional-platforms have been added, specifying linux-aarch64 and osx-arm64.

The build.sh script has also been modified to enhance the build configuration. Key changes include the exportation of the CXXFLAGS variable with the flag -D_LIBCPP_DISABLE_AVAILABILITY for macOS. The CONFIG_ARGS variable is conditionally set based on the target platform, and three new flags have been added to the cmake command: -DBUILD_PYTHON_DOCS=ON, -DBoost_USE_STATIC_LIBS=OFF, and -DWITH_AVX=OFF.

Possibly related PRs

  • Add tttrlib #51927: The changes in this PR involve adding the tttrlib package, which is directly related to the main PR that updates the meta.yaml file for the same package.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between d9e19c2 and 0bf48a1.

📒 Files selected for processing (2)
  • recipes/tttrlib/build.sh (2 hunks)
  • recipes/tttrlib/meta.yaml (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • recipes/tttrlib/meta.yaml
🔇 Additional comments (2)
recipes/tttrlib/build.sh (2)

7-7: LGTM: Proper handling of macOS C++ availability attributes

The addition of -D_LIBCPP_DISABLE_AVAILABILITY flag follows conda-forge's best practices for handling C++ availability attributes on macOS platforms.


21-23: Verify alignment with upstream tttrlib 0.25.1 release

The new CMake flags look good and improve the package:

  • Building Python docs enhances package documentation
  • Using dynamic Boost libraries follows conda packaging best practices
  • Disabling AVX supports broader platform compatibility (especially for aarch64)

Let's verify these changes align with the upstream release:


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@tpeulen tpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump version (0.25.0 -> 0.25.1)

0.25.1 has an improved build process

@mencian mencian added aarch64 Related to adding linux-aarch64 support osx-arm64 Related to adding osx-arm64 support labels Nov 15, 2024
@mencian mencian merged commit 1b0d178 into master Nov 15, 2024
6 checks passed
@mencian mencian deleted the bump/tttrlib branch November 15, 2024 21:46
@mencian
Copy link
Contributor

mencian commented Nov 15, 2024

tttrlib now builds on osx python > 3.10, aarch64, and arm64; thanks for fixing the build so quickly @tpeulen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch64 Related to adding linux-aarch64 support autobump Automatic Version Update new version osx-arm64 Related to adding osx-arm64 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants