Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to forge-std v1 #2010

Closed
wants to merge 10 commits into from
Closed

Migrate to forge-std v1 #2010

wants to merge 10 commits into from

Conversation

TomAFrench
Copy link
Contributor

@TomAFrench TomAFrench commented Nov 14, 2022 •
edited
Loading

Description

This PR updates us to use forge-std as of commit foundry-rs/forge-std@33d4895

It seems like the majority of the issue was us using the old abi encoder. I'm not really sure how we didn't run into this issue early but 🤷. I had to update my foundry version as well to get fuzzing working, the recent changes to the fuzzer meant we had a couple of tests failing due to too many vm.assume calls so I've switch them to use bound. Fixed in other PRs

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

closes #1999

@TomAFrench
Copy link
Contributor Author

I'm running into an issue where WeightedMathTest.testExitSwaps consistently fails locally due to rejecting too many inputs. Seems like some of the recent changes to the fuzzer means that we're sampling inputs which fail more ofter. Running on the intense profile seems to work consistently however.

In order to get the default profile to succeed I need to bump the max rejections to 100k which is annoying and I'd prefer not to do that across the board. I'd like to either tweak the max runs for this test specifically or adjust it to avoid rejecting so many inputs.

@TomAFrench TomAFrench marked this pull request as ready for review November 14, 2022 22:39
@nventuro
Copy link
Contributor

I replaced one of the two assume's with bound, but still get the same error. This is bizarre, since testJoinSwaps has the exact same logic for discarding runs based on weights, but that one doesn't fail.

@TomAFrench
Merge branch 'master' into forge-std-v1
b4991d8 
* master:
  Move LBP storage handling to library (#2015)
  Add new AaveLinearPool deployment (#2012)
  Lint fix. (#2021)
  Introduce PoolRecoveryEnabler (#2013)
  Remove wrong dependency (#2018)
  Improve deployment signers (#2017)
  Use hardhat network helpers (#2016)
  Add index.ts for `deployments/src` (#2014)
  Split LBP contract into LBP and LBPSettings (#1979)
  Add IRateProviderPool (#2005)
  Add ExternalCallLib which checks revert data for malicious data (#2004)
@TomAFrench
Merge branch 'master' into forge-std-v1
4ce589f 
* master: (61 commits)
  Add protocol id disambiguator to AaveLinearPoolFactory (#2115)
  Add veBoostV2 deployment (#2112)
  feat: add EIP1271 support to boostv2 (#2084)
  feat: add infinite allowance for Balancer Vault (#2109)
  chore: rename BoostV2 to VeBoostV2 (#2116)
  Remove salt from veboost domain separator and expose version (#2085)
  Add totalSupply to VotingEscrowDelegationProxy (#2098)
  Deploy L2 Gauge Checkpointer (#2114)
  Nuke distributors package (#2111)
  Replace gauge manager with authorizer adaptor (#2108)
  Deployment preparation: L2 gauge checkpointer (#1601)
  Pull in base for new L2 gauges (#2102)
  Add NullVotingEscrow contract (#2105)
  chore: prevent src directory from being included in package (#2106)
  Remove unused controllers (#2100)
  Add BasePoolMath (#2097)
  Refactor flag getters / setters in managed pool contracts (#2096)
  Bump and pub interface package (#2094)
  Patch deployments package (#2095)
  Deployments v3.1 (#2092)
  ...
@TomAFrench
Copy link
Contributor Author

Checked on latest forge version and this is still an issue.

foundry-rs/foundry#3740

@TomAFrench TomAFrench mentioned this pull request Dec 7, 2022
Merged
11 tasks
@TomAFrench
Merge branch 'master' into forge-std-v1
3a5d5d0 
* master:
  test: always use abi encoder v2 in fuzz tests (#2121)
  Configurable pause window Preparation (#2118)
  Do deployment (#2117)
  Add missing managed factory ids (#2120)
@TomAFrench TomAFrench mentioned this pull request Dec 7, 2022
Merged
11 tasks
TomAFrench and others added 3 commits December 7, 2022 15:58
@TomAFrench
Merge branch 'master' into forge-std-v1
96e55d4 
* master:
  Increase usage of bound over vm.assume (#2122)
@EndymionJkb
Merge branch 'master' into forge-std-v1
b6c1bd4
@TomAFrench
Merge branch 'master' into forge-std-v1
ef87dd7 
* master:
  Update deployments changelog. (#2139)
  Update address lookup (#2140)
  refactor: use SingletonAuthentication instead of Authentication (#2129)
  ProtocolFeeSplitter reorder (#2131)
  ProtocolFeeSplitter sentinel (#2132)
  Update deployments' readmes. (#2138)
  ProtocolFeeSplitter rename treasury (#2130)
  Gnosis deployment (#2136)
  fix: remove extraneous import/dependency (#2135)
  Deploy Aave Linear Factory v3 (#2134)
  remove `20220906-composable-stable-pool` from table of active deployments (#2125)
@EndymionJkb
Copy link
Collaborator

Encompassed by #2448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update forge-std to 1.0.0
3 participants
@TomAFrench @nventuro @EndymionJkb