Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update forge-std to 1.0.0 #1999

Closed
TomAFrench opened this issue Nov 10, 2022 · 2 comments
Closed

Update forge-std to 1.0.0 #1999

TomAFrench opened this issue Nov 10, 2022 · 2 comments

Comments

@TomAFrench
Copy link
Contributor

TomAFrench commented Nov 10, 2022 •
edited by EndymionJkb
Loading

We should update our version of forge-std to 1.0.0. I've updated locally and ran into the error described here: foundry-rs/forge-std#215.

Once this is fixed then we can update.

Update as of 5/2/23: We have updated forge in #2448... but some (different) issues remain. We are getting intermittent failures now on the same two pesky join/exit tests.
@nventuro
Copy link
Contributor

Keep in mind some of our tests will also fail in 1.0.0 and need fixing: see this comment and this other one for a more detailed explanation.

@TomAFrench TomAFrench mentioned this issue Nov 14, 2022
Closed
11 tasks
@jubeira
Copy link
Contributor

jubeira commented Jun 14, 2023

See #2448

@jubeira jubeira closed this as completed Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to forge-std v1 balancer/balancer-v2-monorepo
3 participants
@jubeira @nventuro @TomAFrench