-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new AaveLinearPool deployment #2012
Conversation
pkg/deployments/tasks/20221115-aave-rebalanced-linear-pool/test/test.fork.ts
Outdated
Show resolved
Hide resolved
pkg/deployments/tasks/20221115-aave-rebalanced-linear-pool/test/test.fork.ts
Show resolved
Hide resolved
The build info I get on commit |
Hmm, forge-std might be mucking with the build info here. I'll make a fresh build-info. |
Co-authored-by: Nicolás Venturo <[email protected]>
I've rebuild from c571f1a and get the same build-info. |
This reverts commit 9f099e0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Been trying to get the build info check to pass, but it kept failing. According to @EndymionJkb, this could be because the file you submitted has had formatting applied to it, causing it to differ from the raw hardhat file. I tried a json diff tool and indeed I get a match when comparing them that way.
Could you update the build info so that it doesn't have this formatting applied to it? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified the build info matches what commit 1ae8c3c0d3a94337780bac29697fd7b0cd15d1a6
builds.
* master: Move LBP storage handling to library (#2015) Add new AaveLinearPool deployment (#2012) Lint fix. (#2021) Introduce PoolRecoveryEnabler (#2013) Remove wrong dependency (#2018) Improve deployment signers (#2017) Use hardhat network helpers (#2016) Add index.ts for `deployments/src` (#2014) Split LBP contract into LBP and LBPSettings (#1979) Add IRateProviderPool (#2005) Add ExternalCallLib which checks revert data for malicious data (#2004)
Description
This PR adds a deployment task for the new AaveLinear pool with the fixes to the rebalancer's token approvals and protection for malicious reverts in external calls.
Type of change
Checklist:
master
, or there's a description of how to mergeIssue Resolution