Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new AaveLinearPool deployment #2012

Merged
merged 19 commits into from
Nov 17, 2022
Merged

Conversation

TomAFrench
Copy link
Contributor

Description

This PR adds a deployment task for the new AaveLinear pool with the fixes to the rebalancer's token approvals and protection for malicious reverts in external calls.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

@TomAFrench TomAFrench marked this pull request as ready for review November 15, 2022 15:09
@TomAFrench TomAFrench requested a review from nventuro November 15, 2022 15:30
@nventuro
Copy link
Contributor

The build info I get on commit 362f269a93e84007db6a5c8151e588a01c880576 does not match what is committed here, are you sure you got the right one?

@TomAFrench
Copy link
Contributor Author

The build info I get on commit 362f269a93e84007db6a5c8151e588a01c880576 does not match what is committed here, are you sure you got the right one?

Hmm, forge-std might be mucking with the build info here. I'll make a fresh build-info.

TomAFrench and others added 2 commits November 15, 2022 19:00
* master:
  Remove wrong dependency (#2018)
  Improve deployment signers (#2017)
  Use hardhat network helpers (#2016)
@TomAFrench
Copy link
Contributor Author

The build info I get on commit 362f269a93e84007db6a5c8151e588a01c880576 does not match what is committed here, are you sure you got the right one?

I've rebuild from c571f1a and get the same build-info.

Copy link
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been trying to get the build info check to pass, but it kept failing. According to @EndymionJkb, this could be because the file you submitted has had formatting applied to it, causing it to differ from the raw hardhat file. I tried a json diff tool and indeed I get a match when comparing them that way.

Could you update the build info so that it doesn't have this formatting applied to it? Thanks!

Copy link
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the build info matches what commit 1ae8c3c0d3a94337780bac29697fd7b0cd15d1a6 builds.

@nventuro nventuro merged commit d908fb4 into master Nov 17, 2022
@nventuro nventuro deleted the new-aave-linear-pool-deployment branch November 17, 2022 17:58
TomAFrench added a commit that referenced this pull request Nov 22, 2022
* master:
  Move LBP storage handling to library (#2015)
  Add new AaveLinearPool deployment (#2012)
TomAFrench added a commit that referenced this pull request Nov 22, 2022
* master:
  Move LBP storage handling to library (#2015)
  Add new AaveLinearPool deployment (#2012)
  Lint fix. (#2021)
  Introduce PoolRecoveryEnabler (#2013)
  Remove wrong dependency (#2018)
  Improve deployment signers (#2017)
  Use hardhat network helpers (#2016)
  Add index.ts for `deployments/src` (#2014)
  Split LBP contract into LBP and LBPSettings (#1979)
  Add IRateProviderPool (#2005)
  Add ExternalCallLib which checks revert data for malicious data (#2004)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants