Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split LBP contract into LBP and LBPSettings #1979

Merged
merged 9 commits into from
Nov 15, 2022
Merged

Split LBP contract into LBP and LBPSettings #1979

merged 9 commits into from
Nov 15, 2022

Conversation

TomAFrench
Copy link
Contributor

Description

This PR ports the architecture changes we made to ManagedPool over to LBPs.

  1. Swap, join, exit hooks are moved to their own contract.
  2. We make use of WeightedJoinsLib and WeightedExitsLib.
  3. Some inlining of functions which don't make sense in a flat contract.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

EndymionJkb
EndymionJkb approved these changes Nov 15, 2022
View reviewed changes
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much cleaner now.

pkg/pool-weighted/contracts/lbp/LiquidityBootstrappingPool.sol Show resolved Hide resolved
pkg/pool-weighted/contracts/lbp/LiquidityBootstrappingPool.sol Outdated Show resolved Hide resolved
pkg/pool-weighted/contracts/lbp/LiquidityBootstrappingPoolSettings.sol Outdated Show resolved Hide resolved
@TomAFrench TomAFrench merged commit a9bcfc3 into master Nov 15, 2022
@TomAFrench TomAFrench deleted the lbp-settings branch November 15, 2022 16:11
@TomAFrench TomAFrench mentioned this pull request Nov 15, 2022
Merged
11 tasks
TomAFrench added a commit that referenced this pull request Nov 15, 2022
@TomAFrench
Merge branch 'master' into new-aave-linear-pool-deployment
e1f1bfe 
* master:
  Add index.ts for `deployments/src` (#2014)
  Split LBP contract into LBP and LBPSettings (#1979)
TomAFrench added a commit that referenced this pull request Nov 22, 2022
@TomAFrench
Merge branch 'master' into forge-std-v1
b4991d8 
* master:
  Move LBP storage handling to library (#2015)
  Add new AaveLinearPool deployment (#2012)
  Lint fix. (#2021)
  Introduce PoolRecoveryEnabler (#2013)
  Remove wrong dependency (#2018)
  Improve deployment signers (#2017)
  Use hardhat network helpers (#2016)
  Add index.ts for `deployments/src` (#2014)
  Split LBP contract into LBP and LBPSettings (#1979)
  Add IRateProviderPool (#2005)
  Add ExternalCallLib which checks revert data for malicious data (#2004)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EndymionJkb EndymionJkb EndymionJkb approved these changes

@nventuro nventuro Awaiting requested review from nventuro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAFrench @EndymionJkb