Remove salt from veboost domain separator and expose version #2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nventuro
reviewed
Dec 2, 2022
nventuro
approved these changes
Dec 6, 2022
| @@ -281,7 +280,7 @@ def permit(_owner: address, _spender: address, _value: uint256, _deadline: uint2 | |||
| ) | |||
| ) | |||
|
|
|||
| assert ecrecover(digest, convert(_v, uint256), convert(_r, uint256), convert(_s, uint256)) == _owner | |||
| assert ecrecover(digest, convert(_v, uint256), convert(_r, uint256), convert(_s, uint256)) == _owner and _owner != ZERO_ADDRESS, 'INVALID_SIGNATURE' | |||
TomAFrench
added a commit
that referenced
this pull request
Dec 6, 2022
* master: Remove salt from veboost domain separator and expose version (#2085) Add totalSupply to VotingEscrowDelegationProxy (#2098) Deploy L2 Gauge Checkpointer (#2114) Nuke distributors package (#2111) Replace gauge manager with authorizer adaptor (#2108) Deployment preparation: L2 gauge checkpointer (#1601)
TomAFrench
added a commit
that referenced
this pull request
Dec 7, 2022
* master: (61 commits) Add protocol id disambiguator to AaveLinearPoolFactory (#2115) Add veBoostV2 deployment (#2112) feat: add EIP1271 support to boostv2 (#2084) feat: add infinite allowance for Balancer Vault (#2109) chore: rename BoostV2 to VeBoostV2 (#2116) Remove salt from veboost domain separator and expose version (#2085) Add totalSupply to VotingEscrowDelegationProxy (#2098) Deploy L2 Gauge Checkpointer (#2114) Nuke distributors package (#2111) Replace gauge manager with authorizer adaptor (#2108) Deployment preparation: L2 gauge checkpointer (#1601) Pull in base for new L2 gauges (#2102) Add NullVotingEscrow contract (#2105) chore: prevent src directory from being included in package (#2106) Remove unused controllers (#2100) Add BasePoolMath (#2097) Refactor flag getters / setters in managed pool contracts (#2096) Bump and pub interface package (#2094) Patch deployments package (#2095) Deployments v3.1 (#2092) ...
TomAFrench
added a commit
that referenced
this pull request
Dec 7, 2022
* master: (29 commits) test: always use abi encoder v2 in fuzz tests (#2121) Configurable pause window Preparation (#2118) Do deployment (#2117) Add missing managed factory ids (#2120) Add protocol id disambiguator to AaveLinearPoolFactory (#2115) Add veBoostV2 deployment (#2112) feat: add EIP1271 support to boostv2 (#2084) feat: add infinite allowance for Balancer Vault (#2109) chore: rename BoostV2 to VeBoostV2 (#2116) Remove salt from veboost domain separator and expose version (#2085) Add totalSupply to VotingEscrowDelegationProxy (#2098) Deploy L2 Gauge Checkpointer (#2114) Nuke distributors package (#2111) Replace gauge manager with authorizer adaptor (#2108) Deployment preparation: L2 gauge checkpointer (#1601) Pull in base for new L2 gauges (#2102) Add NullVotingEscrow contract (#2105) chore: prevent src directory from being included in package (#2106) Remove unused controllers (#2100) Add BasePoolMath (#2097) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Needing to know the blockhash for the block prior to when we deployed the veboost contract is a bit crazy so I've removed it. I've also exposed a getter for the version field so we can pull this from onchain.
Type of change
Checklist:
master, or there's a description of how to mergeIssue Resolution