[D8][META] Consider adding modules/features to core for parity with Drupal 8/9/10

[dgoutam]

Based on the presentation by Dave Reid at Drupalcon Amsterdam 2014, the "Core modules" list in d.org and other sources (like the d.org issue queue and the D8 change records).

Modules to be added:

• [D8] Add administration specific language preference #282 | admin_language
• [UX][D8] Merge the "List links" and "Edit menu" operations into a single administration page. #475 | simplified_menu_admin
• [D8][DX] Add Modernizr to core. #1009 | modernizr
• [D8][UX] Add inline form errors #1040 | Inline Form Errors & Inline Messages
• [D8] Port and merge Internationalization in core (feature parity with D8). #1374 | i18n
• [D8] Port and merge Internationalization Views in core #1375 | i18nviews
• [D8] Port and merge Localization Update in core #1377 | l10n_update(https://www.drupal.org/project/field_formatter_settings)
• [D8] Port and merge Local Image Input Filter in core #1384 | filter_html_image_secure
• [UX][D8] Make position of #description (help text) configurable via the API #1403 | Form Element Layout / https://www.drupal.org/project/drupal/issues/314385 / https://www.drupal.org/node/2324025
• [D8][UX] Merge Special Menu Items module functionality in core (allow <nolink> and <separator> menu items). #1840 Merge Special Menu Items module functionality in core | https://www.drupal.org/node/2698057
• [D8][SR] Add the ability to block IP addresses (feature parity with Drupal). #1878 Bring back the "ban IP" feature | https://www.drupal.org/docs/8/core/modules/ban/overview
• [D8][UX] Add hidden and read-only field widgets (for the node edit form). #2101 | Add hidden and read-only field widgets
• [D8][WP] Move to trash instead of deleting. #2498 | Trash / https://www.drupal.org/node/2797395 / https://www.drupal.org/project/drupal/issues/2797247 / https://www.drupal.org/project/ideas/issues/2786135 / https://www.drupal.org/project/drupal/issues/2725449
• [D8] CKEditor: Allow Image Styles to be used with inline images #2658 | CKEditor: Allow Image Styles to be used with inline images
• [D11][UX] Add an easy-to-use 'Remove' button on multi-value fields #314 | multiple_fields_remove_button or field_remove_item: https://www.drupal.org/project/drupal/issues/1038316
• [D8][UX] Save Draft (module) in core #3157 | save_draft
• [UX][D8] Views: Expose responsive classes in the UI via table settings #3656 | Views: Expose responsive classes in the UI via table settings

Other misc changes we might also want to consider:

• [UX][D8] Convert user pictures to an actual Image Field #243 | Convert user pictures to an actual Image Field (2.x)| https://www.drupal.org/node/1292470 (change record: https://www.drupal.org/node/1851200)
• [UX][D8] Allow menu items to be created even if no page exists at that path #422 | Allow menu items to be created even if no page exists at that path | https://www.drupal.org/node/2693725
• [UX][D8] Merge the "List links" and "Edit menu" operations into a single administration page. #475 | Clean up & simplify the menu administration | https://www.drupal.org/node/663946
• Entity bundles should declare both a singular and a plural form of their label #1145 | Entity bundles should declare both a singular and a plural form of their label | https://www.drupal.org/node/23298 / https://www.drupal.org/node/1850080 (change record: https://www.drupal.org/node/2689949)
• [D8] Add new formatter - "URL to Image" to image field in Views #2921 | Add new formatter - "URL to Image" to image field in Views
• [PS][D8] Advanced Drupal Caching (a.k.a. cache tags and cache max-age) #4127 | [PS][D8] Advanced Drupal Caching (a.k.a. cache tags and cache max-age)
• Allow more granular HTML filter options for HTML attributes, not just tags #6100

**Feature parity with the Layout Builder module in modern drupal:

• [UX][D8] Create/select layout for a specific page from the content add/edit form. #1131 | [UX] Create/select layout for a specific page from the content add/edit form.
• Add layout configuration options to the content type admin area. #2894 | [UX] Create/select layout for specific content type from the content type add/edit form.

Modules/features already added:

• Added: entity reference module in core. #1301 | entityreference
• [UX][D8] Allow multiple file/image uploads #1380 | multiupload_filefield_widget
• [UX][D8] Allow multiple file/image uploads #1380 | multiupload_imagefield_widget
• [SR][D8] Port and merge Secure Permissions in core #1382 | secure_permissions
• [D8][WP][UX] Better workflow states and content save options. #1475 | Better workflow states and content save options | https://www.drupal.org/node/282122 / https://www.drupal.org/node/218755 / https://www.drupal.org/node/1777388
• Add views to core #40 | rss_permissions
• Add views to core #40 | views
• [D8][PS] Integrate the functionality of the entity_cache module into core #74 | entity_cache
• Implement a drag & drop model for building layouts #86 | multiblock
• Implement a drag & drop model for building layouts #86 | responsive_bartik
• Add a system of page-less nodes #100 | bean
• [UX] Add Rich Text editor (WYSIWYG) to core #101 | caption_filter
• [UX] Add Rich Text editor (WYSIWYG) to core #101 | ckeditor
• Backport Dialog API #104 | dialog
• Implement "Simple" Views Bulk Operations (VBO) #142 | views_bulk_operations
• [META] Convert listings to Views #151 | admin_views
• [META] CMI conversions #169 | configuration
• [META] CMI conversions #169 | defaultconfig
• Replace/update toolbar with a responsive/touch-friendly version (Replace with Admin Menu) #189 | navbar
• [META] HTML5 for Backdrop #200 | elements
• [META] HTML5 for Backdrop #200 | html5_tools
• Add link (field) module to core #240 | link
• Modules page cleanup #300 | instantfilter
• [D8] Create a new 'Assign user roles' permission #313 | RoleAssign | https://www.drupal.org/project/drupal/issues/267342
• Add the "Entity view mode" module to core #315 | entity_view_mode
• [D8][UX] Add Better Taxonomy permissions #382 | taxonomy_access_fix
• Add email (field) module to core #476 | email
• Add date (field) module to core #478 | date
• Update the views grid style to be responsive #479 | views_responsive_grid
• Add Menu Block features to core (feature parity with D8). #845 | menu_block
• [D8] Add Transliteration to Core #904 | transliteration
• Port and merge Entity API in core (feature parity with D8). #1371 | entity
• [D8] Port and merge Field Formatter Settings in core #1376 | field_formatter_settings / hook_field_formatter_settings_summary_alter() / hook_field_formatter_settings_form_alter()
  Change record: Introduced hooks to extend field formatters and widgets with third-party settings
• Port and merge Date Popup Authored in core (feature parity with D8). #1379 | date_popup_authored
• [D8][SR] Add support for "trusted_host_patterns" (but do not enforce). #2568 | Add support for "trusted_host_patterns" | https://www.drupal.org/node/1992030 / https://www.drupal.org/node/2410395
• [UX] Views: Add a "[hidden]" label to fields when excluded from display #2922 | [DX] Views: Add a "[hidden]" label to fields when excluded from display
• [D8] Provide image style tokens (imagecache_token module in core) #3594 | Expand image tokens to allow image styles (imagecache_token functionality)
• [D8] Add ability to create configurable layout templates #3755 | [D8] Add ability to create configurable layout templates
• [UX] Enable autocomplete on all link/path fields #3764 | [UX] Enable autocomplete on all link/path fields | https://www.drupal.org/node/2418017 / https://www.drupal.org/node/2407913 / Change record: Menu link UI now an autocomplete, with optional manual path entry
• [D8][UX] Use the user_admin_role config setting as a flag to allow all actions, simplify permissions page, remove user_modules_installed #4372 | adminrole (??) / https://www.drupal.org/node/1153072 / https://www.drupal.org/node/787152 / https://www.drupal.org/node/2435075
  Change record: Admin roles are stored on the roles itself
• responsive_table
• uuid
• [D8] theme_table() should take an optional footer variable and produce tfoot #3627 | theme_table() should take an optional footer variable and produce <tfoot>: https://www.drupal.org/project/drupal/issues/806982
• [UX] Node form Submit button text should include Published state #1383

Not planned/needed in Backdrop:

• [PS][D8] Port and merge BigPipe in Backdrop core. #1716 / Performance improvement: render cache. #1413 | https://www.drupal.org/project/big_pipe
• https://www.drupal.org/project/breakpoints
• https://www.drupal.org/project/composer_manager
• https://www.drupal.org/project/composer_vendor
• https://www.drupal.org/project/entity_translation
• https://www.drupal.org/project/escape_admin
• https://www.drupal.org/project/imagecache (already in D7 core)
• https://www.drupal.org/project/joyride
• https://www.drupal.org/project/migrate
• https://www.drupal.org/project/migrate_d2d
• https://www.drupal.org/project/phone
• https://www.drupal.org/project/picture
• https://www.drupal.org/project/pred8
• https://www.drupal.org/project/quickedit
• https://www.drupal.org/project/restws
• http://github.com/Gizra/restful
• https://www.drupal.org/project/title
• https://www.drupal.org/project/entity_modified
• https://www.drupal.org/project/render_cache

Removed from d8 core:

• https://www.drupal.org/node/2116417 refer to https://backdropcms.org/node/28

[dgoutam]

@quicksketch @jenlampton is there any policy document how to include this modules to backdrop for contributors? It will be super helpful if this kinda document exist for the contributors. For me kinda confused how to include these modules (let say joyride) into backdrop.

Could it be simple PR? If so I can take few.

[quicksketch]

Could it be simple PR? If so I can take few.

We have a docs page at https://backdropcms.org/develop/pull-requests on an intro to contribution.

That said, I don't think many of the modules not already included are likely for a 1.0 release. We're planning on releasing in less than 2 months, so adding yet more modules that we haven't even yet begun is a risky endeavor that could push back our release. We could start working on some of these for a later release (e.g. start work on the CKEditor port), but actual inclusion would likely need to wait until after 1.0.

Areas in which we need the most help right now are in Views conversions (#151) and CMI conversions (#169). There are also a number of bugs that we've noticed that are reasonably easy to tackle, and a few security issues (#180). Finally, we've just initially finished Layouts (#86), and we have a number of followups from that in #345.

[attiks]

FYI picture 2.x now works without breakpoints module, if there's interest we can start porting the relevant parts.

[quicksketch]

I think the only relevant portion of the HTML5/picture business that is relevant to Backdrop is the use of srcset (http://css-tricks.com/responsive-images-youre-just-changing-resolutions-use-srcset/), which I'd love to see built directly into Image module. I haven't tried out the Picture module recently to know how extensive it's solution is, but I think if we can focus on solving the problem of matching up an appropriate image to the device resolution, we'll be in good shape.

If it's not over-simplification, I'd love to see this boiled down to just a single (by default enabled) option either the image formatter or on the image style:

[ ] Generate images for high-resolution and mobile displays

That would automatically generate 50% and 200% versions of the given image and update the srcset to use them. Advanced granularity beyond that may be best left to contrib. Thoughts?

[klonos]

That would automatically generate 50% and 200% versions of the given image and update the srcset to use them. Advanced granularity beyond that may be best left to contrib.

Sounds good to me.

[attiks]

@quicksketch srcset will cover most use cases, but the problem is that - for the moment - you'll need to output a picture tag and use the polyfill, if you only use srcset you ran into problems:

• browser without srcset support will prefetch the image specified in src, resulting in a double download
• safari only supports 1x 2x qualifiers so you cannot use sizes, which is the most used form

Generating 50%, 200% versions of the same image is not going to help a lot, assuming you'll only want dpi switching it means it will generate a 0.5x and a 2x version. The 0.5x version will not be used since all devices are art least 1x, the 2x version is not sufficient, since most modern phone are 1.5x, 2x, 3x and I even believe there's a 4x phone.

So the above means that it might be better to add support for srcset and sizes, for the moment in Drupal 7 this boils down to selecting some image styles on the formatter and entering a sizes string. The difficult part is entering the sizes string because it is brand new for most people and a bit difficult to comprehend.

Best explanation can be found at http://ericportis.com/posts/2014/srcset-sizes/

I agree that adding full picture support with media queries, mime type support and sources can be left for contrib.

[quicksketch]

you'll need to output a picture tag and use the polyfill, if you only use srcset you ran into problems:

• browser without srcset support will prefetch the image specified in src, resulting in a double download
• safari only supports 1x 2x qualifiers so you cannot use sizes, which is the most used form

Could we try to plan ahead by essentially leaving <img> output identical to what it is now, but adding in srcset using either the w or x syntax (I'm not sure which would be better)? If we leave polyfill support to contrib, it could override the srcset attributes to set them in a way where double-loading would be prevented. Without a polyfill, the browser would just treat images as they do currently, reading out the normal src attribute.

The 0.5x version will not be used since all devices are art least 1x

You're right it's too early to build in a 0.5x version considering browser support. Once browsers get smarter, a 0.5x version may become a best-practice for supporting mobile or other situations where users are network constrained. A browser knows if it's on a slow connection, and could use the low-resolution image when possible. However, that's just theoretical for now.

The difficult part is entering the sizes string because it is brand new for most people and a bit difficult to comprehend.

After reading that article you referenced, I don't think sizes is something that can be easily understood by site builders. It appears users would need to know the breakpoints of their layout and where the images will be used within that layout. That makes sizes a poor fit conceptually for image styles, which can be used anywhere throughout a site in any number of places. Coupled with different layouts being allowed different breakpoints, asking an end-user to supply sizes is going to be difficult even when they understand how it's supposed to be used.

[jenlampton]

Great conversation going on over here, thanks @attiks for your insight on responsive images! :)

[attiks]

@quicksketch

srcset: w or x syntax?

The w syntax is the preferred way, but it means you'll need to add sizes as well. The easiest to implement is the x syntax and it can be easily done without a polyfill. This can be done without an interface, but we need to pick the right multipliers, I guess to be safe we need: 1x, 1.5x, 2x, 2.5x, 3x

The problem might be that images need to be upscaled, which is something that should be avoided, so we need an easy way to detect this or allow a site builder to disable certain multipliers?

Contrib can add support for sizes using a different image formatter.

[klonos]

...or instead of upscaling, prompt the user to insert the larger image (use it for the larger multiplier) and downscale it for the smaller multipliers. Does that make any sense?

[attiks]

@klonos it sure does make sense, but does this mean we're going to add a validation to make sure the image is at least 2000px wide, or is it just about adding a description to ask the user to insert a big enough image. In the latter case we need to make sure the derivative can be created without upscaling.

[klonos]

Just asking users to insert their largest variant I guess. After some time (either through trial and error or through our documentation), people will be trained to do so anyways.

Checking for minimum size simply does not make sense to me. What would that size be? Would it be acceptable for all use cases?

[klonos]

...added https://www.drupal.org/project/entity

[mikemccaffrey]

@klonos Shouldn't we not need the entity project, since @quicksketch integrated the Entity API functionality into core in #49?

[klonos]

I couldn't possibly answer that question. It's my understanding that with #49 only a subset of the module was merged into core. I don't know what was left out or why or whether there's more to be done in order to be in par with D8. I believe that @quicksketch is the right person to answer that.

I simply added the module to the list because I saw the "This module has been included with Drupal 8 core." section on the project page in d.org. I then checked our list here and saw no mention of it. So I added it. If it is deemed that we need not do anything else, then I'll just close #1371 as a duplicate of #49 and I'll update the list in the issue summary accordingly.

[olafgrabienski]

Added two Views related features: #2921 and #2922.

[klonos]

I have updated the issue summary, and have added #2498

[klonos]

I believe that given that we have the Feature parity with Drupal GitHub project to help us track issues + also the various [Dx] keywords that we are using in the titles of the issues, perhaps we should close this issue here.

I'll leave it open for a while longer, but will close it next time I am brought here unless there are objections to that.