Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX] Add support for skip_permissions_hardening in settings.php #3506

Open
klonos opened this issue Jan 29, 2019 · 0 comments
Open

[DX] Add support for skip_permissions_hardening in settings.php #3506

klonos opened this issue Jan 29, 2019 · 0 comments

Comments

@klonos
Copy link
Member

klonos commented Jan 29, 2019

This is the respective ticket for https://www.drupal.org/project/drupal/issues/1232572 and part of #378

It's common for sites in version control to include a settings.inc file in sites/default that is used to version control site configuration, while keeping sensitive information (keys, passwords, etc) in settings.php. When system_requirements() runs, it will automatically change the permissions of the site directory to remove write permissions. Then, when running git pull, the merge will break because write permissions are missing on the directory.

The skip_permissions_hardening variable can be used to disable chmod'ing files. system_requirements() still throws an error, but I think that's desirable. I'd be open to downgrading the requirement to a warning if this variable is set.

If this approach is sound, we'd still need to add an example to settings.php so it's known that the variable exists.

This has already been implemented in D8, and that ticket is now set to be backported to D7, but similarly to #3459, the way things are progressing for D7, it might be another year+ before we see this being implemented. No reason we can't do it sooner in Backdrop 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant