-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[D8][DX] Add Modernizr to core. #1009
Comments
Step 1) someone should get it in contrib :) |
D8 decided to use a custom build of Modernizr that only included a few key feature detections:
And some minor APIs:
The modular aspect of modernizr means that individual themes could provide additional detections for things they needed specifically. Of note, the most recent place we ran across this was for flexbox detection (#988), which D8 did not include in their out-of-box configuration. As the place we would need this is in the presentation of themes (system.module) and layouts (layout.module), we'd need to include flexbox detection as an additional core item, rather than being in a specific theme like Seven. One thing that has me a bit worried is that Modernizr 3.0 seems to be on the cusp of release. We may be better off in the long run if we write detections where necessary in the interim, and add modernizr after the release. That said, I'm also not opposed to just leaving our own detections in place once we have them, as usually they're short and effective. e.g. when we ported https://www.drupal.org/node/1261002, we just wrote our own touch detection instead of using Modernizr (see backdrop/backdrop#312):
|
This is also part of #378 |
Pinging @domaingood since he mentioned this on Gitter 😉 |
FTR: https://www.drupal.org/project/drupal/releases/9.4.0 (change record: Modernizr touchevents test deprecated)
https://www.drupal.org/project/drupal/issues/3101922
|
This is the same issue as https://www.drupal.org/node/1252178 for D8. This request is not simply in order to bring us in feature parity with D8 - it's been mentioned in various issues like #189, #214, #801 and latest in #988. It was listed in #211 but dropped as N/A back then. Reconsider?
The text was updated successfully, but these errors were encountered: