Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Views: Add a "[hidden]" label to fields when excluded from display #2922

Closed
simone960 opened this issue Dec 17, 2017 · 8 comments
Closed

Comments

@simone960
Copy link

In Drupal 8, if you "Exclude from display" to hide a field...

exclude from display

...the field is labelled as [hidden] in Views. e.g

exclude from display-hidden label

This feature is small but quite useful and important as I always used to name the label with "hidden" when I exclude a field from display in Drupal 7. This practice helps me to see what fields are actually hidden and understand these fields are meant to be used or output somewhere else or in another fields. It also help the developer easily to figure out what's going on in the Views when following up the projects of other developer instead of going round to find out which field is excluded and which is not. I was surprise this small practice which I learnt initially from Chris Shattuck (buildamodule.com) is added to the core in Drupal 8. I believe there's a good point of adding it. So please consider adding to core in the near future as well. Thanks!

@olafgrabienski
Copy link

That's an excellent suggestion! I saw the enhancement in Drupal 8 as well, it's indeed very useful. The feature provides good practice by default and makes the life of site builders much easier.

In Drupal 7 and Backdrop I use to fill in a respective hint by myself as "Administrative title", e.g. Content: Nid [hidden] but that's an annoying repetitive task, and there's always the risk to forget to do it.

@simone960 Do you have the coding skills to provide a PR?

@olafgrabienski olafgrabienski changed the title Request: Adding a "[hidden]" label to the field when exclude from display in Views [DX] Views: Add a "[hidden]" label to fields when excluded from display Dec 18, 2017
@simone960
Copy link
Author

I use to fill in a respective hint by myself as "Administrative title", e.g. Content: Nid [hidden]

Em... that's another good way of doing it. But as you pointed out, it's an annoying repetitive task, whichever way we do, that's always a chance to forget either to do it or to undo it. Default setting will make life easier.

Do you have the coding skills to provide a PR?

I'm afraid not. I'm more familiar with site building and theming. Not a coder really. But I would love to help testing out.

@olafgrabienski
Copy link

Do you have the coding skills to provide a PR?

I'm afraid not. I'm more familiar with site building and theming. Not a coder really. But I would love to help testing out.

Same here, so tagging as "help wanted".

@jenlampton jenlampton changed the title [DX] Views: Add a "[hidden]" label to fields when excluded from display [UX] Views: Add a "[hidden]" label to fields when excluded from display Dec 21, 2017
@jenlampton jenlampton added this to the 1.8.1 milestone Dec 21, 2017
@quicksketch quicksketch modified the milestones: 1.8.1, 1.8.2 Jan 2, 2018
@serundeputy serundeputy modified the milestones: 1.8.2, 1.10.0 Jan 13, 2018
@opi
Copy link

opi commented Jan 19, 2018

Tests for PR backdrop/backdrop#2076 are green \o/

@olafgrabienski
Copy link

Thanks for your help, @opi! I've created a view in the sandbox site with some hidden fields:

screen-backdrop-pr-2076-views-hidden-fields

Works as expected, great!

@simone960
Copy link
Author

Thanks @opi ! I have tested too and all is good ! One small but a life saving feature !

@quicksketch
Copy link
Member

Great addition, thanks @opi for making the PR! Thanks to @olafgrabienski and @simone960 for the testing and suggestion!

I've merged backdrop/backdrop#2076 into 1.x and 1.9.x, this will be in 1.9.1. Thanks!

@quicksketch
Copy link
Member

On version clarification: UX changes with low code impact can be deployed in bug fix releases, so this will be out in 1.9.1 instead of needing to wait for 1.10.0.

@jenlampton jenlampton mentioned this issue May 15, 2018
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants