[META] Layout Followup Issues

[quicksketch]

In #86, we're working on completing the initial introduction of Layouts into Backdrop. That issue took us far, including introducing Layout module, simplifying Block module, providing contexts, access rules, and an expanded block API. However, there are many, many followups to be done. This issue serves as a listing of sub-issues, which may or may not yet have their own dedicated issues.

edit: I have created a GitHub "Project" for all the Layout related issues that were not completed as part of this meta. To view them all see: https://github.com/backdrop/backdrop-issues/projects/13

Completed and merged

• Add TouchPunch jQuery library to core #372 | Add TouchPunch jQuery library to core to make our drag and drop work on touch devices.
• Provide a list of blocks and the modules that provide them #449 | Create a list of blocks and the modules that provide them
• Automatically remove blocks from layouts when a module is uninstalled #570 | Automatically remove blocks from layouts when a module is uninstalled
• [UX] Better layout conditions display. #578 | [UX] Better layout conditions display (currently needs work)
• Resolve conflicting layout style sheet names #597 | Resolve conflicting style sheet names
• [UX] Add Radix layouts to core #698 | Add additional layouts so sites can be built without needing to add either custom or contrib layouts.
• Add hooks for Layout presave/insert/update #767 | Add hooks for Layout presave/insert/update
• Add function to get current active layout on a page #791 | Add function to get current active layout on a page
• [UX] Fix up spacing and hierarchy of Layout page #891 | Clean up the edit layout interface
• [UX] Add a quick search field in the "Add block" dialog. #929 | Add a Views-like search box when adding new blocks
• [UX] Canceling adding a condition should return to the "Add block" dialog. #943 | [UX] Canceling adding a condition should return to the "Add block" dialog (combined with [UX] Block UI: Dynamically load second-step visibility conditions configuration in the same dialog. #1020).
• [UX] Move the Page title settings to a dialog. #952 | [UX] Move Layout Title Settings to a dialog
• Update manager not configured for layouts #958 | Update manager not configured for layouts
• [UX] Clarify layouts terminology #998 | Clarify Layout terminology
• [UX] Block visibility conditions: Improve the is/is-not setting for "Front page" condition. #1017 | [UX] Block visibility conditions: Improve the is/is-not setting for "Front page" condition.
• Add a "Content type" visibility condition for blocks. #1018 | Add a "Content type" visibility condition for blocks.
• [UX] Block settings: Consider renaming "Conditions" fieldset to "Visibility" or "Visibility conditions". #1019 | [UX] Block settings: Consider renaming "Conditions" fieldset to "Visibility" or "Visibility conditions".
• [UX] Block UI: Dynamically load second-step visibility conditions configuration in the same dialog. #1020 | [UX] Block UI: Dynamically load second-step visibility conditions configuration in the same dialog.
• [UX] Block configuration: "dirty" from flag fired even if user cancels adding a condition. #1022 | [UX] Block configuration: "dirty" from flag fired even if user cancels adding a condition. (combined with [UX] Block UI: Dynamically load second-step visibility conditions configuration in the same dialog. #1020).
• Block conditions not displayed as a bullet list in the config block dialogue. #1023 | Block conditions not displayed as a bullet list in the config block dialogue.
• [UX] Move the list of conditions in the block config dialogue below the "+ Add condition" link/button. #1024 | Move the list of conditions in the block config dialogue below the "+ Add condition" link/button.
• backdrop_get_path() doesn't find layouts #1027 | backdrop_get_path() doesn't find layouts
• [UX] Make the layout admin list more informative #1028 | Make the layout list more useful and informative
• Provide an Existing content block for layouts #1076 | Add ability to add "existing node" to a layout
• Layouts: add a visibility condition for selecting a specific entity ID. #1077 | Add a condition for selecting a specific entity ID
• Add a custom text block #1099 | Add a custom text block for non-reusable blocks (reusable blocks already are provided by Block module, but cannot be exported with the Layout config, as they are entities).
• Add blocks for adding individual fields from entities #1100 | Add blocks for adding individual fields from entities
• Add class to layout region. #1300 | Add the ability to add a class to regions
• [UX] Move the list of visibility conditions in the layout add form below the "+ Add condition" link/button. #1547 | [UX] Move the list of visibility conditions in the layout add form below the "+ Add condition" link/button.
• Layouts: Support vocabulary context for the taxonomy/term/% path. #1587 | Add Taxonomy term contexts
• Add ability to enable/disable certain layout templates (add a settings page for Layout module) #1617 | Add ability to enable/disable certain layout templates (add a settings page for Layout module)
• Port the Panels "from block" title setting for layouts, allowing the title of a layout to be pulled from an individual block. #1618 | Port the Panels "from block" title setting for layouts, allowing the title of a layout to be pulled from an individual block (combined with [UX] Move the Page title settings to a dialog. #952)
• [UX] Improve the aesthetic & usability of the place-blocks page. #1935 | Improve the aesthetic of the place-blocks page.

Postponed/not doing

• [UX] Block config: Prevent the user from accidentally creating conditions that never/always display a block. #1021 | [UX] Block config: Prevent the user from accidentally creating conditions that never/always display a block.

More issues are likely necessary. Let's expand this list as we find more suggestions for the module...

[klonos]

Mentioning the addition of TouchPunch makes me want to shamelessly "promote" #159

[duckzland]

Some suggestion that most site builder or themer will need:

1. Somekind of grid system, bootstrap?
2. Ability to inject css id and class
3. Ability to change background, fonts, margins, padding, text alignment etc

I would suggest to take a peek at wp visual composer plugin, although it is not the best coding but their gui served the purpose to help designer create custom layouting with no coding at all.

[ghost]

As far as I can tell, the only way now to see what blocks are available on a site is via the 'Add block' button when editing a layout. I think a nice feature would be to add a listing of available blocks (a sub-page of admin/reports seems appropriate) to allow users to see what modules are providing what blocks.

[docwilmot]

Few issues I uncovered this weekend:

• Layout 'content' panel does not populate with "main page content" block if I override an exisiting node path (eg node/50). I've tried, it doesnt happen. Node/% works.
• Should disable the "Create Layout" button till context ajax process is complete. After youve finished typing in the path, the natural reaction is to immediately click the "Create Layout" button because there is no other action to perform on this page. But if you click the button while the ajax is running you sometimes get ajax error about it being terminated (dont recall the exact error message but its the same one you get if you save a view while its generating a preview).
• Just one time I got a Undefined index: layout in layout_settings_form_validate() error when saving a custom Layout. Its in my logs together with Trying to get property of non-object in layout_settings_form_validate() (line 448 of C:\wamp\www\backdrop\backdropsite\core\modules\layout\includes\layout.admin.inc).. I imagined it was related to the previous issue re ajax, but not sure, and couldnt replicate it. Hadnt done anything different.
• There should be a link to add a custom block from Layouts "add block" panel. Currently you have to leave the Layouts interface, go to custom blocks in the menu, then return to Layouts and click add block to find your new block. Better UX I think if there was a link right there.
• Again in the create layout interface, if you type in the path before you select a Layout or a name for the Layout, when you're done writing the path, ajax runs and gives you an error about the name and field being required. Which is annoying. The validation should ideally be on final submit not on typing the path surely.

[quicksketch]

Again in the create layout interface, if you type in the path before you select a Layout or a name for the Layout, when you're done writing the path, ajax runs and gives you an error about the name and field being required. Which is annoying. The validation should ideally be on final submit not on typing the path surely.

This is actually a much harder problem to solve than it appears. Layout module requires a name before it can start doing anything. The tempstore entry is saved by name, so we can't start doing anything until it is entered. Views has the same problem but gets around it by asking for the name of the view before you are dropped into the main views interface. I don't think introducing a new screen is a good idea for this. We could potentially hide the path option until the name is entered, but I feel like that's misleading the user into thinking the form is shorter than it really is, and would likely cause other UX problems.

Should disable the "Create Layout" button till context ajax process is complete.

Layout 'content' panel does not populate with "main page content" block if I override an exisiting node path (eg node/50). I've tried, it doesnt happen. Node/% works.

Both of these problems are being addressed in #535.

[docwilmot]

Add a custom text block (with token support) for non-reusable blocks (reusable blocks already are provided by Block module, but cannot be exported with the Layout config, as they are entities).

Hadnt noticed this before. This is going to be confusing then, to have three different types of block? Here's a Big Bad Idea: get rid of the current "Custom Blocks" functionality and just have instances of one "Custom Block" block thats added through Layout builder's "Add block" UI.

[quicksketch]

@docwilmot Yeah that's actually pretty much exactly what I was thinking. Only we can't just get rid of all custom blocks in the 1.x cycle, Custom Blocks already a stand-alone module that you can easily disable.

[quicksketch]

Add a custom text block (with token support) for non-reusable blocks (reusable blocks already are provided by Block module, but cannot be exported with the Layout config, as they are entities).

This has now changed. Blocks are in configuration in 1.3.0+ and are going to stick around. See #1428 and #1099.

[mikemccaffrey]

Does #1528 (Allow a layout to be selected on multiple paths) seem like something we can add to this meta list?

[docwilmot]

I've gone through the remaining issues and made a bunch of PRs. The remaining ones: #943, #1020 and #1022 are all related and awaiting some decision on how to proceed. I dont think I agree with #1025 either, so will wait for some further discussion. And I agree with @quicksketch #1021 is going to be very difficult to accomplish given how the BlockAccess class works.

#1300 should propbably use Region Styles but thats not fully implemented yet.

[docwilmot]

@klonos please test https://github.com/docwilmot/backdrop/tree/conditions. Fixes #943 and #1020. Still in-progress, was hoping to finish this morning, but out of time. And will add #1022 in final PR. Thanks.

[klonos]

I will do so, but most likely I'll be able to allocate time over this coming weekend. This one is + backdrop/backdrop#1234 is on my list.

...And will add #1022 in final PR.

...while at it, can you tackle #1622 too that is related to the "dirty" flag not firing?

[docwilmot]

Now have #943, #1020 and #1022 done and working in that PR, needs a nojs fallback so I can fix tests. Otherwise looks good.

[Graham-72]

@docwilmot Great progress! Thanks for all the effort you are putting into this.

[docwilmot]

Thx. These have been lingering too long. Just hope they get reviewed in time to get in 1.4.0.

[mikemccaffrey]

@docwilmot Sorry, I've been busy finding a place to rent in Portland, but will try to review things soon. Luckily, we still have a bit of time before the 1.4.0 release in May.

[docwilmot]

@mikemccaffrey no worries.

And I'm done. The last remaining two I'm not sure if we should. Leaving them there.

The "long term followups" are higher level stuff and will leave to the experts.

[klonos]

...I need to find some time to go through the list of issues in the issue summary. Some of the issues I placed there are under the "Has PR" section while there's no PR for them.

[jenlampton]

Closing this issue since we now have the project https://github.com/backdrop/backdrop-issues/projects/13#card-21014976