Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Move the Page title settings to a dialog. #952

Closed
quicksketch opened this issue May 28, 2015 · 16 comments
Closed

[UX] Move the Page title settings to a dialog. #952

quicksketch opened this issue May 28, 2015 · 16 comments

Comments

@quicksketch
Copy link
Member

Followup from #373.

The title type selection in Layouts is inconsistent with the rest of the UI. All the other configurations are in modals, so I would love to see the "title" area of the page have a similar configure link, and a modal, where we can hide this title type business. (see screenshot below)

The page title also gets lost on the page. It should probably be an "area" and not just a string of text, this can be accomplished with a border (and/or a background), like so:

layout-title

@docwilmot
Copy link
Contributor

Got this working at backdrop/backdrop@1.x...docwilmot:custom-regions. Tests to follow unless any recommendations against this.

title-dialog
page-title

@docwilmot
Copy link
Contributor

PR up.

@klonos
Copy link
Member

klonos commented Mar 7, 2016

I left some feedback over at the PR.

@jenlampton
Copy link
Member

Just pushed a new PR that addresses all of the feedback posted by @klonos on the first PR by @docwilmot

@klonos
Copy link
Member

klonos commented Mar 11, 2016

Tests failed, but I will give it a spin anyways. Just need a few hours to 💤 first 😄

@klonos
Copy link
Member

klonos commented Apr 4, 2016

@jenlampton can you please force the PR so we can get a sandbox?

@klonos
Copy link
Member

klonos commented Apr 4, 2016

I was thinking (will file a separate follow-up) would it be possible and would it make sense to allow tokens to be used in the title field?

@quicksketch
Copy link
Member Author

For my own reference, the latest PR is at backdrop/backdrop#1284.

I gave it a review and it looks great! Nice job @docwilmot and @jenlampton.

The only thing needed here is the existing tests need to be updated. The existing functionally for titles is already tested, just needs fixing. And we need to expand the test coverage to test pulling the title of the page from a block, as that new functionality is also included in this PR.

@jenlampton
Copy link
Member

Rebased and re-pushed. Also, tests updated & expanded!

@klonos
Copy link
Member

klonos commented May 15, 2016

...the PR sandbox throws several "Undefined index" for various regions + a "Invalid argument supplied for foreach()" ...details left as feedback in the PR.

@quicksketch
Copy link
Member Author

We'll have to push this to 1.5.0 I'm afraid. So close! We made a lot of great improvements to Layouts this release.

@quicksketch quicksketch modified the milestones: 1.5.0, 1.4.0 May 16, 2016
@jenlampton
Copy link
Member

Is this something that could go in before 1.5? It's a UX improvement :)

@klonos
Copy link
Member

klonos commented May 16, 2016

Is this something that could go in before 1.5? It's a UX improvement :)

Yes please.

@jenlampton
Copy link
Member

jenlampton commented Jun 17, 2016

Rebased, and rerolled to work with the new colors in #1935. Holding off on updating terminology until we get consensus on that. Either PR can go in first.

@klonos klonos changed the title [UX] Move Layout Title Settings to a dialog [UX] Layout UI: Move the Page title settings to a dialog. Jun 17, 2016
@quicksketch
Copy link
Member Author

Merged backdrop/backdrop#1284 into 1.x for 1.5.0. I assigned @docwilmot credit for the commit as the original author. Great job! This looks great and is so so so much better than those awkward title settings at the top of the page.

@klonos
Copy link
Member

klonos commented Sep 12, 2016

OMG guys, you're on fire!! Another major annoyance fixed 🎉 ...it's hard to keep up with youz.

@jenlampton jenlampton changed the title [UX] Layout UI: Move the Page title settings to a dialog. [UX] Move the Page title settings to a dialog. Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants